[skip changelog] chore: blockstore_gc: minor cleanups #12312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Jul 29, 2024
rvagg
reviewed
Jul 29, 2024
rvagg
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
this seems ok to me; it does move the batch to the top level rather than inside Stream but since I think that only gets called once anyway so it seems fine
will leave it to @ZenGround0 to take a proper look tho
ZenGround0
reviewed
Jul 30, 2024
ZenGround0
approved these changes
Jul 30, 2024
rjan90
pushed a commit
that referenced
this pull request
Aug 12, 2024
* Flush() correctly in case we are in MovingGC * Allow MovingGC to be interrupted by a context + slight refactor * switch to using multierr as per review
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 17, 2024
…ct#12312) * Flush() correctly in case we are in MovingGC * Allow MovingGC to be interrupted by a context + slight refactor * switch to using multierr as per review
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
…ct#12312) * Flush() correctly in case we are in MovingGC * Allow MovingGC to be interrupted by a context + slight refactor * switch to using multierr as per review
ribasushi
added a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this pull request
Aug 20, 2024
…ct#12312) * Flush() correctly in case we are in MovingGC * Allow MovingGC to be interrupted by a context + slight refactor * switch to using multierr as per review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Two standalone fixes around GC - a forgotten
flush()and lack ofctxpropagation.The refator separating the iteration into its own function allows "walking the store with a function", moving a lot of the complexity a step down, leaving just the logic in place for easier read.
cc @ZenGround0 to review, as this used to be their domain