Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: events: remove filter if we fail to add it to the FilterStore #12318

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: events: remove filter if we fail to add it to the FilterStore #12318

merged 1 commit into from
Jul 31, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jul 29, 2024

Fixing a copypasta bug in original, the TipSetFilterManager is used for block filters, EventFilterManager is for events.

@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Jul 29, 2024
@rvagg rvagg requested a review from aarshkshah1992 July 29, 2024 05:53
@rvagg rvagg enabled auto-merge (rebase) July 29, 2024 07:24
@rvagg rvagg requested review from ZenGround0 and Stebalien July 31, 2024 00:51
@rvagg rvagg merged commit d36c93c into master Jul 31, 2024
84 of 85 checks passed
@rvagg rvagg deleted the rvagg/filter-cleanup branch July 31, 2024 01:26
@simlecode simlecode mentioned this pull request Sep 13, 2024
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenGround0 ZenGround0 ZenGround0 approved these changes

@aarshkshah1992 aarshkshah1992 Awaiting requested review from aarshkshah1992

@Stebalien Stebalien Awaiting requested review from Stebalien

Assignees
No one assigned
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @ZenGround0