-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: deprecate "releases" branch by providing clear messaging #12375
Conversation
This is being done in support of #12072
@rjan90 : feel free to take this one over or go a different path. The link to https://github.com/filecoin-project/lotus/blob/master/LOTUS_RELEASE_FLOW.md would need to change if we move that file. |
It looks like the contents of the makefile was deleted unintentionally here: cbb76cf#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52, which is why the checks are failing. I will push a change that restores the contents. |
restore contents of makefile, which seems to have been deleted accidentally
I actually intentionally deleted the makefile contents so that there was a very clear error message if anyone does |
This reverts commit 9de27df.
2024-08-12: Discussed verbally in Zoom that deleting the makefile contents here makes sense. Next steps:
|
…st so they aren't triggered by changes to the releases branch
I have taken a stab at this with fe42667
I did this in #12322 . See https://github.com/filecoin-project/lotus/pull/12322/files#diff-fb3c9ffe7e0886ba95ce77f3809358fd6aa0ca3994f1bd45195d4ce178d68ca4R157 |
Co-authored-by: Phi-rjan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just one additional suggestion on making it exit with a non-zero status code.
Co-authored-by: Phi-rjan <[email protected]>
This is being done as part of of #12374 . There are additional steps that need to be taken though per that tracking issue.