Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use time.Since instead of time.Now().Sub #12801

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

asamuj
Copy link
Contributor

@asamuj asamuj commented Dec 20, 2024

Related Issues

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

@rvagg rvagg added the skip/changelog This change does not require CHANGELOG.md update label Dec 20, 2024
cmd/lotus-miner/storage.go Outdated Show resolved Hide resolved
cmd/lotus-miner/storage.go Outdated Show resolved Hide resolved
storage/paths/local.go Outdated Show resolved Hide resolved
@rvagg
Copy link
Member

rvagg commented Dec 20, 2024

Thanks for this @asamuj, some nice cleanups in here. I have a local branch with all of these time.Since fixes, but I was also working my way through some additional staticcheck complaints before I bothered pushing it, but you beat me to this!
My only request is to wind back the 0 -> 0o changes you've made, otherwise I'm happy with this.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice, thanks

@rvagg rvagg merged commit bbd53a6 into filecoin-project:master Dec 30, 2024
81 checks passed
@asamuj asamuj deleted the chore/time-since branch December 30, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does not require CHANGELOG.md update
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

2 participants