Skip to content

Conversation

@elvin-du
Copy link
Collaborator

@elvin-du elvin-du commented Aug 2, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@elvin-du elvin-du requested a review from Fatman13 August 2, 2023 05:18
@elvin-du elvin-du self-assigned this Aug 2, 2023
@elvin-du elvin-du added the documentation Improvements or additions to documentation label Aug 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #148 (f63ab08) into master (d4a853d) will not change coverage.
Report is 8 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files          41       41           
  Lines        2574     2574           
=======================================
  Hits          891      891           
  Misses       1529     1529           
  Partials      154      154           
Flag Coverage Δ
unittests 34.61% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
example/main.go 0.00% <0.00%> (ø)
wallet_event/listenevent.go 32.87% <ø> (ø)
build/builder.go 89.39% <100.00%> (ø)

Copy link
Contributor

@Fatman13 Fatman13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fatman13
Copy link
Contributor

Fatman13 commented Aug 2, 2023

又触发 CI 了。。。😂

@0x5459
Copy link
Collaborator

0x5459 commented Aug 2, 2023

行,我提个 PR, 让文档别走 CI

@0x5459 0x5459 mentioned this pull request Aug 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Reviewed

Development

Successfully merging this pull request may close these issues.

6 participants