-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: write public stats to our PG DB #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add a runtime dependency on a PG database, using a new database name `spark_public`. Setup database schema migrations executed at service startup. 2. Define the first table `retrievals` to keep stats about all vs succesfull retrievals performed each day. 3. Update the evaluate step to update these stats for each round completed. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
commented
Jan 11, 2024
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Avoid reading process.env.DATABASE_URL deep inside the call stack. Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
Last minute change: let's rename the DB from |
Signed-off-by: Miroslav Bajtoš <[email protected]>
4 tasks
juliangruber
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prototype implementing code for producing stats to power our Spark Public Dashboard. Design doc:
https://pl-strflt.notion.site/DB-for-SPARK-public-data-a79cbb7a0ff5447980b714afdb2645d6
Add a runtime dependency on a PG database, using a new database
name
spark_stats
(originally:). Setup database schema migrations executedspark_public
at service startup.
Define the first table
retrievals
to keep stats about all vssuccesfull retrievals performed each day.
Update the evaluate step to update these stats for each round
completed.
TODO
spark_evaluate
and a new databasespark_stats
Links: