fix: delay evaluation to finish preprocessing #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A temporary hacky fix for #64 Signed-off-by: Miroslav Bajtoš <[email protected]>
Signed-off-by: Miroslav Bajtoš <[email protected]>
juliangruber
approved these changes
May 21, 2024
|
Oops! 
|
bajtos
added a commit
that referenced
this pull request
May 22, 2024
Fix the regression introduced by #224 where the first measurements batch added to a new round triggers the following error: ``` Round index mismatch: 7386 !== 7387 ``` Sentry issue: https://space-meridian.sentry.io/issues/5385606165/?project=4505906069766144 Signed-off-by: Miroslav Bajtoš <[email protected]>
|
Fix: #230 |
bajtos
added a commit
that referenced
this pull request
May 22, 2024
Fix the regression introduced by #224 where the first measurements batch added to a new round triggers the following error: ``` Round index mismatch: 7386 !== 7387 ``` Sentry issue: https://space-meridian.sentry.io/issues/5385606165/?project=4505906069766144 Signed-off-by: Miroslav Bajtoš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary hacky fix for #64. See also #209.