fix: limit the delay between tasks to 60s #98
Merged
+57
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure the checker prints some message at least once per minute, to prevent Station Core for considering it as stuck. As a side effect, this also fixes the problem when maxTasksPerRound is zero, the delay is calculated as Infinity and we call `setTimeout(Infinity)`. Such call is a no-op in Deno, which causes the checker to loop very quickly and pollute the logs with too many "Completed all tasks for the current round." messages. After this change, the message is print once per minute. Signed-off-by: Miroslav Bajtoš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the checker prints some message at least once per minute, to prevent Station Core for considering it as stuck.
As a side effect, this also fixes the problem when maxTasksPerRound is zero, the delay is calculated as Infinity and we call
setTimeout(Infinity). Such call is a no-op in Deno, which causes the checker to loop very quickly and pollute the logs with too many "Completed all tasks for the current round." messages.After this change, the message is print once per minute.
Links: