Skip to content

Re-enable shelf action feature #17308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

d2dyno1
Copy link
Member

@d2dyno1 d2dyno1 commented Jul 24, 2025

Resolved / Related Issues

This PR introduces minor changes, unless additional changes are requested. The file watcher was implemented quite some time ago and already works properly, thanks to #16900 and #16728. This PR focuses solely on re-enabling this feature, but can be iterated upon to accommodate any undocumented missing features (if any? - not that I'm aware of)

  • Re-enabled the command for showing the Shelf pane in production
  • Add a "Create link" menu option when dropping an item from the shelf to a folder
  • Add a delete bulk action
  • Add "View in parent folder" menu option
  • Fixed Shelf's file watcher reference counter logic
  • ?

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Opened Files
  2. Confirmed the action shows up appropriately
  3. Confirmed the menu and bulk actions work properly
  4. Confirmed that deleting two (or more) files from the same folder using the bulk delete action properly removes them from the Shelf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add 'Shelf' pane to take bulk actions on items from different paths
1 participant