Skip to content

Code Quality: Prevent exceptions when available size is zero or negative #17477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

Code Quality: Prevent exceptions when available size is zero or negative #17477

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1f8a98
Fix: Prevent exceptions when available size is zero or negative
seer-by-sentry[bot] Aug 20, 2025
813a61a
Update BreadcrumbBarLayout.cs
yaira2 Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/Files.App.Controls/BreadcrumbBar/BreadcrumbBarLayout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,21 @@ protected override Size MeasureOverride(NonVirtualizingLayoutContext context, Si
var accumulatedSize = new Size(0, 0);
_availableSize = availableSize;

// Ensure we have a minimum size to prevent DivideByZeroException in WinUI
// When availableSize has zero dimensions, provide a minimal positive size for measurement
var measureSize = new Size(
Math.Max(availableSize.Width, 1.0),
Math.Max(availableSize.Height, 1.0)
);

var indexAfterEllipsis = GetFirstIndexToRender(context);

// Go through all items and measure them
for (int index = 0; index < context.Children.Count; index++)
{
if (context.Children[index] is BreadcrumbBarItem breadcrumbItem)
{
breadcrumbItem.Measure(availableSize);
breadcrumbItem.Measure(measureSize);
accumulatedSize.Width += index < indexAfterEllipsis ? 0 : breadcrumbItem.DesiredSize.Width;
accumulatedSize.Height = Math.Max(accumulatedSize.Height, breadcrumbItem.DesiredSize.Height);
}
Expand Down Expand Up @@ -98,6 +105,10 @@ private int GetFirstIndexToRender(NonVirtualizingLayoutContext context)
var itemCount = context.Children.Count;
var accumulatedWidth = 0d;

// Handle zero or negative available width - hide all items
if (_availableSize.Width <= 0)
return itemCount;

// Go through all items from the last item
for (int index = itemCount - 1; index >= 0; index--)
{
Expand Down
Loading