Fix: Fixed an issue where Columns View was incorrectly enabled for Recycle Bin #17803
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unexpected behavior with file system hierarchy display. The Columns layout is now disabled when viewing the Recycle Bin to prevent navigation issues.
|
@workbysaran what happens if the user has the 'sync layout preferences' option enabled and has the default layout set to Columns? |
…ce sync is enabled.
|
I have updated the LayoutPreferencesManager to handle the scenario when the "Sync layout preferences" setting is enabled. |
… unexpected behavior with file system hierarchy display. The Columns layout is now disabled when viewing the Recycle Bin to prevent navigation issues.
…ce sync is enabled.
yaira2
force-pushed
the
sg/fix-disable-collayout-recyclebin
branch
from
cbc4965 to
bb070b0
Compare
|
Thanks! Does this PR supersede #17792? |
|
I found a scenario where Recycle Bin still uses Columns:
|
yaira2
changed the title
Yes, it does! |
…de is set to Columns with sync disabled.
…com/workbysaran/Files into sg/fix-disable-collayout-recyclebin
yaira2
reviewed
Oct 29, 2025
…onflict resolution
yaira2
reviewed
Oct 30, 2025
|
|
||
| private static LayoutPreferencesItem? GetLayoutPreferencesForPath(string path) | ||
| { | ||
| if (path.StartsWith(Constants.UserEnvironmentPaths.RecycleBinPath, StringComparison.Ordinal)) |
There was a problem hiding this comment.
Can you add a code comment explaining why we disable Columns View in Recycle Bin?
yaira2
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Fixed an issue where using Column View in the Recycle Bin caused unexpected behavior with file system hierarchy display. The Columns layout is now disabled when viewing the Recycle Bin to prevent navigation issues.
Closes #13654
Steps used to test these changes