Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump peerDependency react to include 18.0.0 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simian-loco
Copy link

Resolves issue #41

@mikaelengstrom
Copy link

@erikras - Could you review and merge this? Would appreciate it very much :)

@simian-loco
Copy link
Author

simian-loco commented Mar 14, 2023

@mikaelengstrom @erikras -- This change eventually broke for me. It fixed my build and I only had a couple of implementations so I opened this merge up; but I did find that it eventually broke. I can't exactly remember what it was that broke; but I think it was a react API call somewhere which was incompatible with React 18. I ended up just refactoring out the two listener implementations I was using and removed this package from my dependencies.

I would close this merge as breaking; but perhaps this might be a good place for related discussion? @mikaelengstrom could you bump locally in your node_modules/react-final-form-listeners/package.json and see which react API call this breaks on? I think I was using onChange.

Edit: added some details

05/05/23 Update - I'll defer to others here regarding everything working as expected as I cannot reproduce the issue I mentioned above at this time and it was a pretty convoluted abstraction in the first place where the error was occurring.

@mikaelengstrom
Copy link

@simian-loco seems to work just fine in our app

@SwinX
Copy link

SwinX commented May 5, 2023

@erikras may you please consider merging this? We're maintaining pretty large project on React@18 with 50+ usages of library in huge forms. And still everything works as expected.

@peiofour
Copy link

peiofour commented Dec 7, 2023

Hello, it is possible to merge this please?

@andremacnamara
Copy link

@erikras Is this good to merge in?

@comet-code-andrew
Copy link

Is this going to be merge?

@gordonk
Copy link

gordonk commented Feb 3, 2024

I too would love to see this merged

Copy link
Author

@simian-loco simian-loco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikras Looks like this is good to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants