Merge pull request #508 from willow-ahrens/wma/fix_einsum

reduce style correctly
finch-tensor · Apr 26, 2024 · e1c46b0 · e1c46b0 · willow-ahrens · Apr 26, 2024
2 parents 0ffa443 + 3e78a76
commit e1c46b0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Finch"
 uuid = "9177782c-1635-4eb9-9bfb-d9dfa25e6bce"
 authors = ["Willow Ahrens"]
-version = "0.6.22"
+version = "0.6.23"
 
 [deps]
 AbstractTrees = "1520ce14-60c1-5f80-bbc7-55ef81b5835c"

diff --git a/src/interface/einsum.jl b/src/interface/einsum.jl
@@ -33,7 +33,7 @@ einsum_access(tns::EinsumTensor, idxs...) = EinsumArgument{eltype(tns.arg)}(
 )
 
 einsum_op(op, args::EinsumArgument...) = EinsumArgument{combine_eltypes(op, args)}(
-    result_style((arg.style for arg in args)...),
+    reduce(result_style, [arg.style for arg in args]; init=EinsumEagerStyle()),
     mapjoin(op, (arg.data for arg in args)...),
     mergewith(&, (arg.extrude for arg in args)...),
     op((arg.default for arg in args)...)

diff --git a/test/test_interface.jl b/test/test_interface.jl
@@ -8,6 +8,13 @@ using Finch: AsArray
         using Test
 
         @testset "Einsum Tests" begin
+            # Test 0
+            A = [1 2; 3 4]
+            B = [5 6; 7 8]
+            s = Scalar(0)
+            @einsum s[] += abs(A[i, k] * B[k, j])
+            @test s[] == 134
+
             # Test 1
             A = [1 2; 3 4]
             B = [5 6; 7 8]