Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@findify/sdk): expose request types as JS object in SDK #810

Merged
merged 1 commit into from
May 24, 2022
Merged

fix(@findify/sdk): expose request types as JS object in SDK #810

merged 1 commit into from
May 24, 2022

Conversation

timaramazanov
Copy link
Contributor

Summary

To fix this issue: #809 I've added RequestType to the exposed objects of the SDK

I don't want to replace RequestType enum with string type as it will require quite a lot of refactoring in MJS projects (a lot of projects use RequestType enum)

pascalachkar
pascalachkar approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@pascalachkar pascalachkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we will need to double check the whole exposed type later down the road

@timaramazanov timaramazanov merged commit 4bfd561 into master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalachkar pascalachkar pascalachkar approved these changes

@Bitaru Bitaru Awaiting requested review from Bitaru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timaramazanov @pascalachkar @timram