Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for conversion deps when using refiners.conversion #463

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Laurent2916
Copy link
Member

small test snippet:

cd /tmp
python3 -m venv .venv
. .venv/bin/activate

pip install refiners@git+https://github.com/finegrain-ai/refiners@pr/check_refiners_conversion_deps
python -c 'import refiners.conversion' # should fail, with message: Some dependencies are missing: ... Please install refiners with the `conversion` extra, e.g. `pip install refiners[conversion]`
pip install refiners[conversion]@git+https://github.com/finegrain-ai/refiners@pr/check_refiners_conversion_deps
python -c 'import refiners.conversion' # should work

@Laurent2916 Laurent2916 requested a review from deltheil October 14, 2024 14:54
@Laurent2916 Laurent2916 self-assigned this Oct 14, 2024
@Laurent2916 Laurent2916 force-pushed the pr/check_refiners_conversion_deps branch from c909276 to 9fb8344 Compare October 15, 2024 08:36
@Laurent2916 Laurent2916 merged commit 9b19272 into main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants