Skip to content

Commit

Permalink
Merge pull request #39 from finn-no/readme-update
Browse files Browse the repository at this point in the history
Update README.md with info about transitioning delegate
  • Loading branch information
osanoj authored Jan 29, 2021
2 parents 0aba4e5 + 54ef389 commit c491c25
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ bottomSheetView.present(in: viewController.view, targetIndex: 0)

## Known limitations

Using `.bottomSheetAutomatic`:
### Using `.bottomSheetAutomatic`:

When using `.bottomSheetAutomatic` to calculate the content height and your view is constrained using the `layoutMarginsGuide`, you must be aware that the returned content height may actually be higher than the compressed layout size of your view. Also, it may result in the transition animation freezing. This problem is avoided simply by not using the `layoutMarginsGuide`.

### BottomSheetTransitioningDelegate

To avoid "glitches" you might need to keep a strong reference to the transitioning delegate (`BottomSheetTransitioningDelegate`) until the bottom sheet animation is complete.

0 comments on commit c491c25

Please sign in to comment.