Skip to content

Commit

Permalink
Remove warnings and delete outdated code (#369)
Browse files Browse the repository at this point in the history
  • Loading branch information
ninarg authored Sep 21, 2021
1 parent 397bf14 commit 2db3994
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 86 deletions.
4 changes: 0 additions & 4 deletions CharcoalDemo/CharcoalDemo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
79CC225C25D682F100E165BE /* DemoTableViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 79CC224C25D682F100E165BE /* DemoTableViewController.swift */; };
79CC226125D6835E00E165BE /* DemoViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 79CC225F25D6835E00E165BE /* DemoViewController.swift */; };
79CC226225D6835E00E165BE /* DemoTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = 79CC226025D6835E00E165BE /* DemoTableViewCell.swift */; };
79CC226525D686B200E165BE /* CHANGELOG.md in Resources */ = {isa = PBXBuildFile; fileRef = 79CC226425D686B200E165BE /* CHANGELOG.md */; };
79CC227A25D6A5F900E165BE /* FilterContainerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 79CC227925D6A5F900E165BE /* FilterContainerTests.swift */; };
79CC22C025D6C14200E165BE /* Charcoal in Frameworks */ = {isa = PBXBuildFile; productRef = 79CC222F25D67CE000E165BE /* Charcoal */; };
79CC22C125D6C14200E165BE /* SnapshotTesting in Frameworks */ = {isa = PBXBuildFile; productRef = 79CC228425D6A63C00E165BE /* SnapshotTesting */; };
Expand Down Expand Up @@ -75,7 +74,6 @@
79CC224C25D682F100E165BE /* DemoTableViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DemoTableViewController.swift; sourceTree = "<group>"; };
79CC225F25D6835E00E165BE /* DemoViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DemoViewController.swift; sourceTree = "<group>"; };
79CC226025D6835E00E165BE /* DemoTableViewCell.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = DemoTableViewCell.swift; sourceTree = "<group>"; };
79CC226425D686B200E165BE /* CHANGELOG.md */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = net.daringfireball.markdown; path = CHANGELOG.md; sourceTree = "<group>"; };
79CC227725D6A5F900E165BE /* SnapshotTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = SnapshotTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };
79CC227925D6A5F900E165BE /* FilterContainerTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FilterContainerTests.swift; sourceTree = "<group>"; };
79CC227B25D6A5F900E165BE /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
Expand Down Expand Up @@ -128,7 +126,6 @@
79CC221825D67B8600E165BE /* CharcoalDemo */ = {
isa = PBXGroup;
children = (
79CC226425D686B200E165BE /* CHANGELOG.md */,
79CC225E25D6835E00E165BE /* Utils */,
79CC224025D682F000E165BE /* Components */,
79CC224725D682F000E165BE /* DataSource.swift */,
Expand Down Expand Up @@ -317,7 +314,6 @@
buildActionMask = 2147483647;
files = (
79CC222625D67B8700E165BE /* LaunchScreen.storyboard in Resources */,
79CC226525D686B200E165BE /* CHANGELOG.md in Resources */,
79CC222325D67B8700E165BE /* Assets.xcassets in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
Expand Down
73 changes: 0 additions & 73 deletions CharcoalDemo/CharcoalDemo/CHANGELOG.md

This file was deleted.

9 changes: 1 addition & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,6 @@ _Charcoal_ /ˈtʃɑːkəʊl/: _a porous black solid, consisting of an amorphous
<img src="/GitHub/demo.gif"/>
</p>

**Making a new Demo release**
1. Update Demo/CHANGELOG.md
2. Update version for Demo target in Xcode
3. Install fastlane with bundler if it is not already there. Run `bundle install`.
4. Run `sh Scripts/version.sh` to update build number
5. Run `bundle exec fastlane` and follow instructions

## Installation

### CocoaPods
Expand Down Expand Up @@ -70,7 +63,7 @@ Add this line to your `Package.swift`. We may not always update the version stri
check the list of [available tags](https://github.com/finn-no/charcoal-ios/tags) and select the newest one.

```swift
.package(url: "https://github.com/finn-no/charcoal-ios.git", .from("10.0.0"))
.package(name: "Charcoal", url: "https://github.com/finn-no/charcoal-ios.git", from: "10.0.0")
```

Don't forget to add `Charcoal` as a dependency to your intended target!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ private func == (lhs: CLLocationCoordinate2D, rhs: CLLocationCoordinate2D) -> Bo
return (fabs(lhs.latitude - rhs.latitude) <= 1e-5) && (fabs(lhs.longitude - rhs.longitude) <= 1e-5)
}

private extension MKPolygonRenderer {
extension MKPolygonRenderer {
open override func applyStrokeProperties(to context: CGContext, atZoomScale zoomScale: MKZoomScale) {
super.applyStrokeProperties(to: context, atZoomScale: zoomScale)
UIGraphicsPushContext(context)
Expand Down

0 comments on commit 2db3994

Please sign in to comment.