Allow renaming of metric fields. #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe it would be better to use the builder pattern for setting the various names, something like
|
|
Hi Stig. Frankly, I already lost context since it was busy time, but looking at my commits now (and running "mvn test" once again just to be sure) it seems that I actually pushed out the changes I intended to push. Could you please take another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
In our project we have somewhat different scheme of metrics naming, for example "hit.count" instead of "hitCount".
Would you mind including such change? Note that I am new to Java so this PR might need further work - just let me know.
Best regards,
Alexey Nezhdanov