-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address CodeQL issues #462
Conversation
Signed-off-by: vaibssingh <[email protected]>
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
===========================================
- Coverage 57.15% 46.98% -10.18%
===========================================
Files 39 39
Lines 1055 1060 +5
===========================================
- Hits 603 498 -105
- Misses 452 562 +110 ☔ View full report in Codecov by Sentry. |
Signed-off-by: vaibssingh <[email protected]>
…xy into 412-fix-codeql-issues Signed-off-by: vaibssingh <[email protected]>
412 fix codeql issues
Signed-off-by: vaibssingh <[email protected]>
fix: fix stack and secure cookie issues
Thank you @vaibssingh ! The PR looks good to me, but maybe @JamieSlome and @coopernetes can have another look at it and merge. Given your contributions to Git Proxy - @vaibssingh , I was wondering if you'd be interested to join our bi-weekly Zoom meeting where we coordinate around project activities; if that's the case, please email [email protected] and I'll send out all the info you need to join. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: vaibssingh <[email protected]>
I would love to! I will be sending the email soon :) |
…odeql-issues Signed-off-by: vaibssingh <[email protected]>
remove unused variable Co-authored-by: Jamie Slome <[email protected]>
…-issues Signed-off-by: vaibssingh <[email protected]>
…xy into 412-fix-codeql-issues Signed-off-by: vaibssingh <[email protected]>
Signed-off-by: vaibssingh <[email protected]>
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
@JamieSlome should I look into the issue being reported by Socket regarding the postintall script too? |
@vaibssingh - nothing to do on your end 👍 Bit strange how Socket is reporting new dependencies when none of these dependencies are being added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Address CodeQL issues
Fixes #412
Moved the session secret to .env file. Also added rate limiter, csrf protection, stop returning error stack and add
secure
attribute to cookie. This PR fixes all the issues being flagged by CodeQL.