Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce CSRF protection with Lusca ❤️ #497 #499

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

JamieSlome
Copy link
Member

Closes #492

@JamieSlome JamieSlome added the bug Something isn't working label Mar 22, 2024
@JamieSlome JamieSlome self-assigned this Mar 22, 2024
Copy link

netlify bot commented Mar 22, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 0285857
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/66014ac410a553000872cec8

@JamieSlome
Copy link
Member Author

@maoo - it seems like the checks are still running on the repository? Any ideas?

Copy link

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

License Issues

package.json

PackageVersionLicenseIssue Type
lusca^1.7.0NullUnknown License
Allowed Licenses: MIT, Apache-2.0, BSD-3-Clause, ISC, BSD-2-Clause, Unlicense, CC0-1.0, 0BSD, X11, MPL-2.0, MPL-1.0, MPL-1.1, MPL-2.0

OpenSSF Scorecard

PackageVersionScoreDetails
npm/lusca 1.7.0 🟢 3.2
Details
CheckScoreReason
Code-Review🟢 5found 7 unreviewed changesets out of 15 -- score normalized to 5
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ -1no tokens found
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies⚠️ -1no dependencies found
Dangerous-Workflow⚠️ -1no workflows found
Security-Policy🟢 10security policy file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Fuzzing⚠️ 0project is not fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities⚠️ 033 existing vulnerabilities detected
npm/tsscmp 1.0.6 🟢 3.7
Details
CheckScoreReason
Code-Review🟢 5found 6 unreviewed changesets out of 12 -- score normalized to 5
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ -1no dependencies found
Dangerous-Workflow⚠️ -1no workflows found
Packaging⚠️ -1packaging workflow not detected
Token-Permissions⚠️ -1no tokens found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Fuzzing⚠️ 0project is not fuzzed
Vulnerabilities🟢 100 existing vulnerabilities detected
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
npm/lusca ^1.7.0 🟢 3.2
Details
CheckScoreReason
Code-Review🟢 5found 7 unreviewed changesets out of 15 -- score normalized to 5
Maintained⚠️ 00 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ -1no tokens found
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies⚠️ -1no dependencies found
Dangerous-Workflow⚠️ -1no workflows found
Security-Policy🟢 10security policy file detected
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Fuzzing⚠️ 0project is not fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Vulnerabilities⚠️ 033 existing vulnerabilities detected

Scanned Manifest Files

package-lock.json
package.json
  • lusca@^1.7.0

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@a6717e4). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage        ?   57.35%           
=======================================
  Files           ?       39           
  Lines           ?     1060           
  Branches        ?        0           
=======================================
  Hits            ?      608           
  Misses          ?      452           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome JamieSlome merged commit ad05a96 into main Mar 25, 2024
13 checks passed
@JamieSlome JamieSlome deleted the 492-error-csrf-token-missing branch March 25, 2024 10:05
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
Re-introduce CSRF protection with Lusca ❤️ finos#497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: CSRF token missing 🐛
1 participant