Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add npm run build step to CI workflow #575

Merged
merged 3 commits into from
May 23, 2024

Conversation

tt-gideonaryeetey
Copy link
Contributor

Including the build step would integrate the frontend build into the package on the npm registry, which should resolve the UI error that occurs when users follow the installation instructions.

Copy link

linux-foundation-easycla bot commented May 22, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented May 22, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 1cb67d3
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/664f47410ba566000891ebe0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.96%. Comparing base (a14b744) to head (1cb67d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   56.96%   56.96%           
=======================================
  Files          46       46           
  Lines        1566     1566           
=======================================
  Hits          892      892           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 8b3e4c9 into finos:main May 23, 2024
13 checks passed
Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
chore: add npm run build step to CI workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants