Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added a CI step to detect unused dependencies #592

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

divinetettey
Copy link
Contributor

adding this PR to resolve this issue Implement a CI step to detect unused dependencies 📦

The changes include:

  1. installing the depcheck package
  2. Running depcheck --oneline --skip-missing
  3. Fail if the the check fails

Copy link

linux-foundation-easycla bot commented Jun 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d4110dc
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6671832eace2b600082ae6be

@divinetettey divinetettey changed the title Added a CI step to detect unused dependencies chore: added a CI step to detect unused dependencies Jun 5, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.39%. Comparing base (0ba98b2) to head (d4110dc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          46       46           
  Lines        1582     1582           
=======================================
  Hits          908      908           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieSlome
Copy link
Member

@divinetettey - is there any chance we can move the check to its own workflow file? What do you think?

@divinetettey
Copy link
Contributor Author

divinetettey commented Jun 13, 2024

@divinetettey - is there any chance we can move the check to its own workflow file? What do you think?

I think that's fine, we can go with that approach

@JamieSlome
Copy link
Member

@divinetettey - thanks for making the adjustments (perfect 🎉 ). It seems like the depcheck is reporting that concurrently and a few other devDependencies are unused which is not the case. Is there any way to add these to an allow list or as permissible exceptions?

@divinetettey
Copy link
Contributor Author

divinetettey commented Jun 18, 2024

@divinetettey - thanks for making the adjustments (perfect 🎉 ). It seems like the depcheck is reporting that concurrently and a few other devDependencies are unused which is not the case. Is there any way to add these to an allow list or as permissible exceptions?

I have added them to the ignore list. I would take a deep dive into how depcheck performs the checks

@JamieSlome
Copy link
Member

@maoo - can we make unused dependencies required on status checks to main please?

Copy link
Member

@JamieSlome JamieSlome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍰

@JamieSlome JamieSlome merged commit 76348c8 into finos:main Jun 18, 2024
14 checks passed
@maoo
Copy link
Member

maoo commented Jun 18, 2024

@maoo - can we make unused dependencies required on status checks to main please?

Done!

Psingle20 pushed a commit to Psingle20/git-proxy that referenced this pull request Nov 27, 2024
…ndencies

chore: added a CI step to detect unused dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants