-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added a CI step to detect unused dependencies #592
chore: added a CI step to detect unused dependencies #592
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 57.39% 57.39%
=======================================
Files 46 46
Lines 1582 1582
=======================================
Hits 908 908
Misses 674 674 ☔ View full report in Codecov by Sentry. |
@divinetettey - is there any chance we can move the check to its own workflow file? What do you think? |
I think that's fine, we can go with that approach |
@divinetettey - thanks for making the adjustments (perfect 🎉 ). It seems like the |
…rrently) in depcheck command
I have added them to the ignore list. I would take a deep dive into how depcheck performs the checks |
…-dependencies.yml
@maoo - can we make unused dependencies required on status checks to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🍰
Done! |
…ndencies chore: added a CI step to detect unused dependencies
adding this PR to resolve this issue Implement a CI step to detect unused dependencies 📦
The changes include:
depcheck --oneline --skip-missing