Skip to content

Conversation

Sabarivasan-Velayutham
Copy link

Issue : Increase test coverage to 80% ⚡️ #240

This pull request introduces test cases for the push action to improve the overall test coverage of the codebase. A small but impactful increase in test coverage has been achieved as part of this effort.

Key Updates:

  • Added new test files for the push action in the test folder.
  • Improved coverage for functions, lines, and other code aspects related to the push action module.
  • Executed nyc to analyze the current test score and identify areas for improvement.
  • Attached a screenshot of the updated test coverage report for reference.

Changes Made

  • Created new test files for push action.
  • Improved test coverage for the module using targeted test cases.
  • Validated changes using nyc coverage reports.

Evidence

Below is the screenshot of the test coverage report for push action :

image


Checklist

  • Code changes have been tested locally.
  • Test cases have been added/updated.
  • Verified improvements in test coverage using nyc.

Copy link

CLA Not Signed

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for endearing-brigadeiros-63f9d0 ready!

Name Link
🔨 Latest commit d9fff66
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/6737c69b77d5ce0008276dcb
😎 Deploy Preview https://deploy-preview-805--endearing-brigadeiros-63f9d0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kriswest
Copy link
Contributor

kriswest commented Sep 8, 2025

This looks like it was a solid contribution, I'm sorry it didn't get merged. I think that much of this work has now been superseded in the project, and we never got a signed CLA allowing us to merge it. Hence, I think it time to close this PR.

However, if you know there are things in here that we don't yet have and would like help completing a CLA get in touch, either here or with [email protected].

@kriswest kriswest closed this Sep 8, 2025
@Sabarivasan-Velayutham
Copy link
Author

Hi @kriswest , I have already raised the EasyCLA authorization request several times but haven’t received an approval email yet. I have submitted it again now, and the approver shows as Rhyddian Olds.

Could you help me please approve the EasyCLA request and reopen this branch for merge once it’s approved?

Thanks!

@kriswest
Copy link
Contributor

kriswest commented Sep 8, 2025

Note if the request has been approved you need to hit the 'click here to be authorised' link again to be rechecked, which isn't obvious. If it's not that you'll need help from Rhydian.

@Sabarivasan-Velayutham
Copy link
Author

Sabarivasan-Velayutham commented Sep 9, 2025

Hi @kriswest , I didn't get any approval notification/mail for this till now. Even yesterday I have given approval request , but still didn't get any response. Please check on this. By the way, I don't have contact to reach Rhydian to ask on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants