[Draft] Persistence Component: Separating out Partitioning from Unitemporal Snapshot milestoning #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…napshot milestoning
rengam32
changed the title
…estoning schemes + logic for unitemporal snapshot with partition without digest
…m/rengam32/legend-engine into unitemp-snap-partition-delete-all
rengam32
commented
Dec 24, 2024
|
|
||
| List<Condition> whereClauseForPartition = new ArrayList<>((Arrays.asList(openRecordCondition, notExistsWhereClause))); | ||
| if (!(partitioning.isPresent() && partitioning.get().deleteStrategy() == DeleteStrategy.DELETE_ALL)) |
There was a problem hiding this comment.
refactor to interfaces instead of enum?
kumuwu
reviewed
Dec 26, 2024
Comment on lines
+116
to
+121
| if (unitemporalSnapshot.digestField().isPresent()) | ||
| { | ||
| return Optional.of(unitemporalSnapshot | ||
| .digestField().get()); | ||
| } | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Suggested change
| if (unitemporalSnapshot.digestField().isPresent()) | |
| { | |
| return Optional.of(unitemporalSnapshot | |
| .digestField().get()); | |
| } | |
| return Optional.empty(); | |
| return unitemporalSnapshot.digestField(); |
Comment on lines
+127
to
+132
| if (unitemporalDelta.digestField().isPresent()) | ||
| { | ||
| return Optional.of(unitemporalDelta | ||
| .digestField().get()); | ||
| } | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Suggested change
| if (unitemporalDelta.digestField().isPresent()) | |
| { | |
| return Optional.of(unitemporalDelta | |
| .digestField().get()); | |
| } | |
| return Optional.empty(); | |
| return unitemporalDelta.digestField(); |
Comment on lines
+138
to
+143
| if (bitemporalSnapshot.digestField().isPresent()) | ||
| { | ||
| return Optional.of(bitemporalSnapshot | ||
| .digestField().get()); | ||
| } | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Suggested change
| if (bitemporalSnapshot.digestField().isPresent()) | |
| { | |
| return Optional.of(bitemporalSnapshot | |
| .digestField().get()); | |
| } | |
| return Optional.empty(); | |
| return bitemporalSnapshot.digestField(); |
Comment on lines
+149
to
+154
| if (bitemporalDelta.digestField().isPresent()) | ||
| { | ||
| return Optional.of(bitemporalDelta | ||
| .digestField().get()); | ||
| } | ||
| return Optional.empty(); |
There was a problem hiding this comment.
Suggested change
| if (bitemporalDelta.digestField().isPresent()) | |
| { | |
| return Optional.of(bitemporalDelta | |
| .digestField().get()); | |
| } | |
| return Optional.empty(); | |
| return bitemporalDelta.digestField(); |
Comment on lines
+29
to
+33
| @Value.Default | ||
| default boolean failOnDuplicatePrimaryKeys() | ||
| { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Is there a reason for adding this? failOnDuplicatePrimaryKeys is a concept under NoVersioning, which seems independent of partitioning
Comment on lines
+94
to
+97
| if (digestField.isPresent()) | ||
| { | ||
| remainingCols = Arrays.asList(digestField.get()); | ||
| } |
There was a problem hiding this comment.
we need to have an else block to actually return the remaining columns (i.e. data columns)
| .condition(And.of(whereClauseForNotInSink)) | ||
| .addFields(FieldValue.builder().datasetRef(mainDataset().datasetReference()).fieldName(ingestMode().digestField()).build()) | ||
| .build())); | ||
| FieldValue.builder().datasetRef(stagingDataset().datasetReference()).fieldName(ingestMode().digestField().get()).build(), |
There was a problem hiding this comment.
Let's use .orElseThrow in these places
| Selection.builder() | ||
| .source(mainDataset()) | ||
| .condition(And.of(whereClauseForNotInSink)) | ||
| .addFields(FieldValue.builder().datasetRef(mainDataset().datasetReference()).fieldName(ingestMode().digestField().get()).build()) |
There was a problem hiding this comment.
Let's use .orElseThrow in these places
kumuwu
reviewed
Dec 27, 2024
| if (digestField.isPresent()) | ||
| { | ||
| this.digestMatchCondition = LogicalPlanUtils.getDigestMatchCondition(mainDataset(), stagingDataset(), transactionMilestoned.digestField().get()); | ||
| this.primaryKeysMatchCondition = LogicalPlanUtils.getPrimaryKeyMatchCondition(mainDataset(), stagingDataset(), primaryKeys.toArray(new String[0])); |
There was a problem hiding this comment.
Suppose this is a mistake? primaryKeysMatchCondition should be initialized with or without digest - correcting this in my branch
Comment on lines
+94
to
+97
| if (digestField.isPresent()) | ||
| { | ||
| remainingCols = Arrays.asList(digestField.get()); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Improvement
What does this PR do / why is it needed ?
Introducing new interfaces for Partitioning and abstracting it out from Unitemporal Snapshot milestoning.
Which issue(s) this PR fixes:
None
Other notes for reviewers:
Does this PR introduce a user-facing change?
No