change Package children to be set of PackageableElement instead of ar…

…ray for performance
finos · Mar 18, 2022 · 2ad12bd · 2ad12bd
1 parent b138cf1
commit 2ad12bd
Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.changeset/clean-tools-walk.md b/.changeset/clean-tools-walk.md
@@ -0,0 +1,5 @@
+---
+'@finos/legend-graph': patch
+---
+
+Change `Package` children to be set of `PackageableElement` instead of array for performance.
diff --git a/packages/legend-graph/src/models/metamodels/pure/packageableElements/domain/Package.ts b/packages/legend-graph/src/models/metamodels/pure/packageableElements/domain/Package.ts
@@ -23,7 +23,6 @@ import {
   type Hashable,
   hashArray,
   assertTrue,
-  addUniqueEntry,
   AssertionError,
 } from '@finos/legend-shared';
 import {
@@ -58,7 +57,7 @@ export class Package extends PackageableElement implements Hashable {
   }
 
   addChild(value: PackageableElement): void {
-    addUniqueEntry(this.children, value);
+    this.children.push(value);
   }
 
   addElement(element: PackageableElement): void {