improve Legend Query and Legend Taxonomy performance
#1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dcbb459 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
=======================================
Coverage 41.66% 41.66%
=======================================
Files 1158 1175 +17
Lines 52393 52441 +48
Branches 11948 11880 -68
=======================================
+ Hits 21827 21849 +22
- Misses 30499 30524 +25
- Partials 67 68 +1
|
akphi
force-pushed
the
faster
branch
3 times, most recently
from
395c7c1 to
6b2a9fd
Compare
3 tasks
akphi
force-pushed
the
faster
branch
3 times, most recently
from
397e49f to
47685cf
Compare
MauricioUyaguari
approved these changes
Jul 20, 2022
| Added a new query creation mode from data space, this will mode can be accessed from `Legend Query` using the `url pattern` | ||
|
|
||
| ``` | ||
| /query/extensions/{groupId}:{artifactId}:{versionId}/{dataSpacePath}/{executionContext}/{runtimePath}? |
There was a problem hiding this comment.
why is runtimePath an option here
There was a problem hiding this comment.
Since people are picking the execution context of a data space which already specified with a default runtime. When people pick another option other than the default runtime, we will put that in the url with this param
|
Updated #936 to reflect some of the work done in this PR |
5 tasks
|
@MauricioUyaguari This potentially also fixes #1092 so we should check that with some substantial-sized graphs |
2 tasks
jinanisha
pushed a commit
to jinanisha/legend-studio
that referenced
this pull request
Aug 5, 2022
* query-builder: remove the link between query setup and editor * update custom eslint rules post ESM import upgrades * query builder: add new simplified graph analytics * docker: update finos/legend-shared-server to avoid CVEs * query: optimize service execution query loading flow * cleanup usage of depot client methods * query: optimize create query from mapping and runtime flow * query builder: temporarily hide error indicator for incompatible mapping * query builder: relax mapping runtime setup checks * reorder parameters of execution-related methods in AbstractPureGraphManager * tracer: remove usage of terminology 'span' * fixes tests and cleanup post rebase * data space: use engine analytics API for loading up dataspaces * legend-query: create QueryEditorStore and simplify LegendQueryStore * legend-query: polomorphize QueryEditorStore * move getExtraApplicationPageRenderEntries() to @finos/legend-application * query: new query creation mode from data-space * add and update changeset * query: make query editor URL more consistent * use HOC for store provider wrapper components * taxonomy: use data space analytics API for loading * bump dependencies * minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Legend TaxonomyandLegend Query- closes Feature request: Improve UX when loading dataspaces #936useQuerySetupStore->useSetupStoreLegendQueryLegendQueryEditorStoreand movegraphStateManagerinto that fromLegendQueryStoreLegend Querytestss post editor store refactoringGAV coordinate ({groupId}:{artifactId}:{versionId})instead of{groupId}/{artifactId}/{versionId}formLegend Taxonomyuse the new data space analytics APIengine- fix problem with dataspace analytics endpoint legend-engine#807depotclient to supportversion aliasesdepotclient methods to make the code more organizedmapto ending withindexto better reflect their usagecontextual documentationexecution-related methods inAbstractPureGraphManagerto make them more consistent with the rest of the methodsHow did you test this change?