Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: improve performance to load cache data #3885

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

gs-gunjan
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 062486c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@finos/legend-application-data-cube Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-vscode-extension-dependencies Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.35%. Comparing base (096ff0e) to head (062486c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3885      +/-   ##
==========================================
- Coverage   46.36%   46.35%   -0.01%     
==========================================
  Files        2255     2255              
  Lines      394526   394502      -24     
  Branches    11788    11015     -773     
==========================================
- Hits       182925   182879      -46     
- Misses     210936   211185     +249     
+ Partials      665      438     -227     
Files with missing lines Coverage Δ
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% <0.00%> (ø)

... and 249 files with indirect coverage changes

@gs-gunjan gs-gunjan marked this pull request as ready for review February 11, 2025 11:48
@gs-gunjan gs-gunjan requested a review from a team as a code owner February 11, 2025 11:48
@akphi akphi merged commit dd00138 into finos:master Feb 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants