-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assessment Definitions: add an 'mandatory_comment' flag #6708
Comments
This may be better on the |
Tasks:
|
The create/update panels are a bit trickier. The create panel is fine as it uses a single form for both fields. The update panel uses in-line editors for both the rating and comment. You can change the rating to one that does not require a comment, clear and save the comment, then change the rating to one that does require a comment. As the rating is now being saved independently from the comment we cannot enforce the rule.... Will look at switching the editor over to using a single form rather than multiple independent edit controls, |
- updated the DDL #CTCTOWALTZ-2827 finos#6708
- updated model and dao #CTCTOWALTZ-2827 finos#6708
- updated admin screens #CTCTOWALTZ-2827 finos#6708
- update screen 'sort of' respects mandatory flag - create screen enforces mandatory flag Github issue explains why I've said 'sort of'. Basically you can trick the editor into saving a rating without a comment. #CTCTOWALTZ-2827 finos#6708
Description
We want some assessment ratings to always be accompanied by a user supplied comment.
To do this we need to:
assessment_definition::mandatory_comment
- booleanrating_scheme_item::mandatory-comment
- booleanRequestor: AP
Resourcing
We would like to add this request to the Waltz team's feature backlog
The text was updated successfully, but these errors were encountered: