Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assessment Definitions: add an 'mandatory_comment' flag #6708

Closed
davidwatkins73 opened this issue Aug 17, 2023 · 4 comments
Closed

Assessment Definitions: add an 'mandatory_comment' flag #6708

davidwatkins73 opened this issue Aug 17, 2023 · 4 comments
Assignees
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Milestone

Comments

@davidwatkins73
Copy link
Member

davidwatkins73 commented Aug 17, 2023

Description

We want some assessment ratings to always be accompanied by a user supplied comment.
To do this we need to:

  • add a column - assessment_definition::mandatory_comment - boolean
    • rating_scheme_item::mandatory-comment - boolean
  • update the ui control to enforce this
  • show in the admin screen
  • stretch: offer a bulk set/unset option
  • do we need a minimum size instead ?
    • for now we will use a default of >0 chars (after trimming)

Requestor: AP

Resourcing

We would like to add this request to the Waltz team's feature backlog

@davidwatkins73 davidwatkins73 added the noteworthy probably worth mentioning in release notes label Aug 17, 2023
@davidwatkins73 davidwatkins73 added this to the next : 1.54 milestone Aug 17, 2023
@davidwatkins73 davidwatkins73 added the DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database label Aug 29, 2023
@davidwatkins73
Copy link
Member Author

This may be better on the rating_scheme_item

@davidwatkins73 davidwatkins73 self-assigned this Jan 17, 2024
@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Jan 17, 2024

Tasks:

  • update ddl
  • add column remarks
  • update model object
  • update dao read/write
  • update admin screens
    • display item
    • display list of items
    • edit
  • update assessment editor to enforce
    • create
    • update

@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Jan 18, 2024

Admin List

Showing the new column.

image


Admin Edit

Showing the new edit field.

image

@davidwatkins73
Copy link
Member Author

The create/update panels are a bit trickier. The create panel is fine as it uses a single form for both fields. The update panel uses in-line editors for both the rating and comment.

You can change the rating to one that does not require a comment, clear and save the comment, then change the rating to one that does require a comment. As the rating is now being saved independently from the comment we cannot enforce the rule....

Will look at switching the editor over to using a single form rather than multiple independent edit controls,

deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jan 19, 2024
- updated the DDL

#CTCTOWALTZ-2827
finos#6708
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jan 19, 2024
- updated model and dao

#CTCTOWALTZ-2827
finos#6708
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jan 19, 2024
- updated admin screens

#CTCTOWALTZ-2827
finos#6708
deutschebank-sync pushed a commit to deutschebank/waltz that referenced this issue Jan 19, 2024
- update screen 'sort of' respects mandatory flag
- create screen enforces mandatory flag

Github issue explains why I've said 'sort of'.  Basically you can trick the editor into saving a rating without a comment.

#CTCTOWALTZ-2827
finos#6708
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database fixed (test & close) An issue has been fixed, merged into master and is ready for further testing noteworthy probably worth mentioning in release notes
Projects
None yet
Development

No branches or pull requests

1 participant