mandatory comments on assessments #6950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated the DDL #CTCTOWALTZ-2827 finos#6708
- updated model and dao #CTCTOWALTZ-2827 finos#6708
- updated admin screens #CTCTOWALTZ-2827 finos#6708
- update screen 'sort of' respects mandatory flag - create screen enforces mandatory flag Github issue explains why I've said 'sort of'. Basically you can trick the editor into saving a rating without a comment. #CTCTOWALTZ-2827 finos#6708
Merge in WALTZ/waltz from WALTZ/waltz-dw:CTCTOWALTZ-2827-mandatory-rating-comments-6708 to db-feature/waltz-6708-mandatory-comments-on-assessments * commit 'f532c994c23c62b238f9ad1df697792ec6149428': Allow rating scheme items to mandate comments Allow rating scheme items to mandate comments Allow rating scheme items to mandate comments Allow rating scheme items to mandate comments
|
davidwatkins73
deleted the
db-contrib/waltz-6708-mandatory-comments-on-assessments
branch
deutschebank-sync
restored the
db-contrib/waltz-6708-mandatory-comments-on-assessments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6708