Add semantic segmentation support #38
Conversation
| @@ -188,6 +188,7 @@ if(${BUILD_ROCAL}) | |||
| ./include/readers/image/ | |||
| ./include/readers/video/ | |||
| ./include/pipeline/ | |||
| ./../../thirdparty/coco_RLE/include/ | |||
There was a problem hiding this comment.
Is this a cloned repo or just a single cpp file? If its a repo, better to add it as a dependency in Dockerfile and figure out how to import the RLE structs from there since they removed all 3rd party libs from rocAL and added them as dependencies
There was a problem hiding this comment.
Sure Sundar. We can discuss on it
| std::map<std::string, std::shared_ptr<MetaData>> _map_content; | ||
| std::map<std::string, std::shared_ptr<MetaData>>::iterator _itr; | ||
| std::map<std::string, ImgSize> _map_img_sizes; | ||
| std::map<std::string, ImgSize> ::iterator itr; | ||
| std::map<int, int> _label_info; | ||
| std::map<int, int> _label_info = {{1,1},{2,2},{3,3},{4,4},{5,5},{6,6},{7,7},{8,8}, \ |
There was a problem hiding this comment.
Hardcoding the contiguous label mapping for coco is not preferred. Use a for loop to generate the mapping in meta_data_reader.cpp where its needed
There was a problem hiding this comment.
We already have this support right @SundarRajan28 ?
There was a problem hiding this comment.
This label generation can't be done on-fly like mask in semantic and it needs this information while storing RLE value
| @@ -238,8 +425,6 @@ void COCOMetaDataReader::read_all(const std::string &path) | |||
| parser.SkipValue(); | |||
| } | |||
| } | |||
| _label_info.insert(std::make_pair(id, continuous_idx)); | |||
There was a problem hiding this comment.
This will break mask training and possibly future SSD trainings. Please add this back and try to transform the pixelwise mask labels after this if its needed
There was a problem hiding this comment.
Yes please do not remove this part
| std::map<std::string, std::shared_ptr<MetaData>> _map_content; | ||
| std::map<std::string, std::shared_ptr<MetaData>>::iterator _itr; | ||
| std::map<std::string, ImgSize> _map_img_sizes; | ||
| std::map<std::string, ImgSize> ::iterator itr; | ||
| std::map<int, int> _label_info; | ||
| std::map<int, int> _label_info = {{1,1},{2,2},{3,3},{4,4},{5,5},{6,6},{7,7},{8,8}, \ |
There was a problem hiding this comment.
We already have this support right @SundarRajan28 ?
| void rleFrString(RLE *R, char *s, siz h, siz w); |
There was a problem hiding this comment.
Please add a line at end of the file.
Bumps [rocm-docs-core](https://github.com/RadeonOpenCompute/rocm-docs-core) from 0.18.3 to 0.18.4. - [Release notes](https://github.com/RadeonOpenCompute/rocm-docs-core/releases) - [Changelog](https://github.com/RadeonOpenCompute/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v0.18.3...v0.18.4) --- updated-dependencies: - dependency-name: rocm-docs-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add semantic reader support in tensor branch