Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing framework #131

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Add testing framework #131

wants to merge 39 commits into from

Conversation

matildeRivas
Copy link
Contributor

@matildeRivas matildeRivas commented Feb 20, 2025 •
edited
Loading

  • Include test target in makefile
  • Include catch2 dependency in workflows and Dockerfile
  • Include sample test
  • Add tests to workflow

@matildeRivas matildeRivas requested a review from fdobad February 20, 2025 21:26
@matildeRivas matildeRivas self-assigned this Feb 20, 2025
@matildeRivas matildeRivas linked an issue Feb 20, 2025 that may be closed by this pull request
Add testing framework to verify simulations #113
Open
@matildeRivas
Copy link
Contributor Author

@fdobad En verdad tal vez no es necesario agregar catch2 a los build, solo se usaría en el workflow de test

fdobad
fdobad reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@fdobad fdobad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20250220_213941_GitHub.jpg

Oh no!

@matildeRivas matildeRivas marked this pull request as ready for review February 24, 2025 12:59
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
4268eae 
…113-add-testing-framework
@matildeRivas
Move catch2 header into wf
021ffda
@matildeRivas
Move catch2 header into wf
ccfd6b1
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
bebf6d0 
…113-add-testing-framework
@matildeRivas
[fix] Store catch2 header in test folder
b10ebfc
@matildeRivas
[fix] Store catch2 header in test folder
71c5237
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
e54d641 
…113-add-testing-framework
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
46c6480 
…113-add-testing-framework
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
0ffbf8f 
…113-add-testing-framework
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
55f12a8 
…113-add-testing-framework
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
75cfd12 
…113-add-testing-framework
@matildeRivas
[fix] add catch2 to include path
5e63064
@matildeRivas
[fix] add catch2 to include path in linux build
61d38db
@matildeRivas
[fix] add catch2 to include path in linux build
93e3101
@matildeRivas
Merge remote-tracking branch 'origin/113-add-testing-framework' into …
d9adc67 
…113-add-testing-framework

# Conflicts:
#	.github/workflows/build-manylinux.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdobad fdobad fdobad left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@matildeRivas matildeRivas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing framework to verify simulations
2 participants
@matildeRivas @fdobad