Flame length for crown fires in spain model #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add output of byram intensity and flame length for crown fires.
7 tasks
…-length-for-crown-fires-in-spain-model # Conflicts: # .gitignore # Cell2Fire/Cell2Fire.cpp # Cell2Fire/FuelModelSpain.cpp
fdobad
requested changes
Jan 14, 2025
…' into 87-flame-length-for-crown-fires-in-spain-model # Conflicts: # Cell2Fire/Cell2Fire.cpp # Cell2Fire/Cell2Fire.h # Cell2Fire/Cells.cpp # Cell2Fire/Cells.h # Cell2Fire/DataGenerator.cpp # Cell2Fire/DataGenerator.h # Cell2Fire/FuelModelKitral.cpp # Cell2Fire/FuelModelSpain.cpp # Cell2Fire/Lightning.cpp # Cell2Fire/ReadArgs.cpp # Cell2Fire/ReadArgs.h # Cell2Fire/ReadCSV.cpp
Le pondré tree height porque canopy height es lo que calculo a partir de (tree_)height-cbh |
|
@fdobad Ya está listo para revisar |
fdobad
requested changes
Jan 16, 2025
There was a problem hiding this comment.
hasta ahora bien, voy a integrar con el plugin y vemos.
Si entendi bien, al menos la especificacion de nuevos outputs esta aca fire2a/fire-analytics-qgis-processing-toolbox-plugin#90
| @@ -478,7 +481,10 @@ Cells::manageFire(int period, | |||
| std::vector<float>& surfFraction, | |||
| std::vector<float>& Intensities, | |||
There was a problem hiding this comment.
Intensities -> SurfaceIntensities
Cell2Fire/Cell2Fire.h
Outdated
There was a problem hiding this comment.
los nombres de las carpetas y los archivos deberia estar aca, y no en .cpp
Cell2Fire/Cell2Fire.cpp
Outdated
There was a problem hiding this comment.
resumen ok?
SB C K
IgnitionsHistory / ignitions_log.csv x x x
Grids / Grids num / ForestGrid%s.csv x x x OutputGrids FinalGrid
Messages / MessagesFile%d.asc x x x OutMessages
RateOfSpread / RosFile%d.asc x x x OutRoss
- Intensity / Intensity%d.asc x x x OutIntensity
+ SurfaceIntensity / SurfaceIntensity%d.asc x x x OutIntensity
+ CrownIntensity / CrownIntensity%d.asc x _ _ OutIntensity AllowCROS
- FlameLength / FL%d.asc x x x OutFl
+ SurfaceFlameLength / SurfaceFlameLength %d.asc x x x OutFl
+ CrownFlameLength / CrownFlameLength %d.asc x _ _ OutFl AllowCROS
+ MaxFlameLength / MaxFlameLength %d.asc x _ _ OutFl AllowCROS
CrownFire / Crown%d.asc x x x OutCrown AllowCROS
CrownFractionBurn / Cfb%d.asc x x x OutCrownConsumption AllowCROS
SurfFractionBurn / Sfb%d.asc _ x _ OutSurfConsumption AllowCROS
…rown-fires-in-spain-model # Conflicts: # test/target_results.zip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cambios realizados: