-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Add TOTP support in Project and Tenant config #682
Open
pragatimodi
wants to merge
28
commits into
master
Choose a base branch
from
mfa-totp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Added TOTP Support for Tenant 3. Added Unit Tests for MFA Config 4. Added Unit Tests for Tenant Config with respect to MFA
2. Unit tests for project_config_mgt 3. Formatting changes
2. Integration tests for project and tenant wrt MFA config
It's useful to be able to navigate to the release notes easily from the package index when upgrading. "Release Notes" is a special keyword that will have the scroll icon in the project page. A random example: * https://pypi.org/project/streamlit/ * https://github.com/streamlit/streamlit/blob/815a3ea6fa3e7f9099b479e8365bd3a5874ddc35/lib/setup.py#L111 Co-authored-by: Lahiru Maramba <[email protected]>
pragatimodi
force-pushed
the
mfa-totp
branch
2 times, most recently
from
May 26, 2023 18:03
cd7aed2
to
0684915
Compare
renkelvin
reviewed
Jun 1, 2023
renkelvin
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with comments.
Importing configs directly fix warnings fix warnings fix warnings
kevinthecheung
requested changes
Jun 14, 2023
Co-authored-by: Kevin Cheung <[email protected]>
kevinthecheung
approved these changes
Sep 8, 2023
Co-authored-by: Kevin Cheung <[email protected]>
Co-authored-by: Kevin Cheung <[email protected]>
kevinthecheung
approved these changes
Jan 9, 2024
Xiaoshouzi-gh
approved these changes
Jan 19, 2024
@kevinthecheung @Xiaoshouzi-gh do we have an ETA on this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOTP Support for Project and Tenant
RELEASE NOTES: Added
TOTP
as a multi-factor option in project and tenant configuration.