-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(functions): Add task queue API support #751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great overall! Added a few comments.
Let's make sure we have enough test coverage for resource name parsing functions
lahirumaramba
changed the title
Draft implementation of task queue
feat(functions): Implementation task queue API support
Jan 24, 2024
lahirumaramba
changed the title
feat(functions): Implementation task queue API support
feat(functions): Add task queue API support
Jan 24, 2024
Thanks for the review! Going to throw the unit and integration tests into the PR after this one. |
lahirumaramba
approved these changes
Jan 25, 2024
jonathanedey
added a commit
that referenced
this pull request
Feb 13, 2024
* Draft implementation of task queue * fix lint * Error handling, code review fixes and typos
jonathanedey
added a commit
that referenced
this pull request
Feb 15, 2024
…st coverage (#767) * feat(functions): Add task queue API support (#751) * Draft implementation of task queue * fix lint * Error handling, code review fixes and typos * feat(functions): Add unit and integration tests for task queue api support (#764) * Unit and Integration tests for task queues. * fix: copyright year * fix: remove commented code * feat(functions): Added `uri` task option and additional task queue test coverage * Removed uri and add doc strings * fix removed typo * re-add missing uri changes * fix missing check
jonathanedey
added a commit
that referenced
this pull request
Feb 27, 2024
* feat(functions): Add task queue API support (#751) * Draft implementation of task queue * fix lint * Error handling, code review fixes and typos * feat(functions): Add unit and integration tests for task queue api support (#764) * Unit and Integration tests for task queues. * fix: copyright year * fix: remove commented code * feat(functions): Added `uri` task option and additional task queue test coverage (#767) * feat(functions): Add task queue API support (#751) * Draft implementation of task queue * fix lint * Error handling, code review fixes and typos * feat(functions): Add unit and integration tests for task queue api support (#764) * Unit and Integration tests for task queues. * fix: copyright year * fix: remove commented code * feat(functions): Added `uri` task option and additional task queue test coverage * Removed uri and add doc strings * fix removed typo * re-add missing uri changes * fix missing check * fix: TW requested changes * fix: Added extra note for full list of replaced headers and undo Content-Type change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes implementation of: