Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): Add task queue API support #751

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Jan 2, 2024

Includes implementation of:

  • Functions Service
  • taskqueue
  • enqueue
  • delete
  • TaskOptions

@jonathanedey jonathanedey marked this pull request as ready for review January 2, 2024 18:21
@lahirumaramba lahirumaramba self-assigned this Jan 2, 2024
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great overall! Added a few comments.
Let's make sure we have enough test coverage for resource name parsing functions

firebase_admin/functions.py Outdated Show resolved Hide resolved
firebase_admin/functions.py Show resolved Hide resolved
firebase_admin/functions.py Show resolved Hide resolved
firebase_admin/functions.py Outdated Show resolved Hide resolved
@lahirumaramba lahirumaramba changed the title Draft implementation of task queue feat(functions): Implementation task queue API support Jan 24, 2024
@lahirumaramba lahirumaramba changed the title feat(functions): Implementation task queue API support feat(functions): Add task queue API support Jan 24, 2024
@jonathanedey
Copy link
Contributor Author

Thanks for the review! Going to throw the unit and integration tests into the PR after this one.

@jonathanedey jonathanedey merged commit dbfdb6e into task-queue Jan 25, 2024
9 checks passed
@jonathanedey jonathanedey deleted the je-task-queue branch January 25, 2024 19:28
jonathanedey added a commit that referenced this pull request Feb 13, 2024
* Draft implementation of task queue

* fix lint

* Error handling, code review fixes and typos
jonathanedey added a commit that referenced this pull request Feb 15, 2024
…st coverage (#767)

* feat(functions): Add task queue API support (#751)

* Draft implementation of task queue

* fix lint

* Error handling, code review fixes and typos

* feat(functions): Add unit and integration tests for task queue api support (#764)

* Unit and Integration tests for task queues.

* fix: copyright year

* fix: remove commented code

* feat(functions): Added `uri` task option and additional task queue test coverage

* Removed uri and add doc strings

* fix removed typo

* re-add missing uri changes

* fix missing check
jonathanedey added a commit that referenced this pull request Feb 27, 2024
* feat(functions): Add task queue API support (#751)

* Draft implementation of task queue

* fix lint

* Error handling, code review fixes and typos

* feat(functions): Add unit and integration tests for task queue api support (#764)

* Unit and Integration tests for task queues.

* fix: copyright year

* fix: remove commented code

* feat(functions): Added `uri` task option and additional task queue test coverage (#767)

* feat(functions): Add task queue API support (#751)

* Draft implementation of task queue

* fix lint

* Error handling, code review fixes and typos

* feat(functions): Add unit and integration tests for task queue api support (#764)

* Unit and Integration tests for task queues.

* fix: copyright year

* fix: remove commented code

* feat(functions): Added `uri` task option and additional task queue test coverage

* Removed uri and add doc strings

* fix removed typo

* re-add missing uri changes

* fix missing check

* fix: TW requested changes

* fix: Added extra note for full list of replaced headers and undo Content-Type change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants