Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation for Fetching and Caching Server Side Remote Config #825

Merged
merged 11 commits into from
Nov 15, 2024

Conversation

pijushcs
Copy link

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@pijushcs pijushcs changed the title Ssrc fetch Implementation for Fetching and Caching Server Side Remote Config Oct 30, 2024
@pijushcs pijushcs requested a review from erikeldridge November 7, 2024 16:20
Copy link

@erikeldridge erikeldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

To over-communicate, I'm approving this change as a member of the App Config team for merging into a feature branch. I expect there will be a subsequent review from the Admin team before this change can be merged into the main branch.

firebase_admin/remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Outdated Show resolved Hide resolved
tests/test_remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Show resolved Hide resolved
firebase_admin/remote_config.py Outdated Show resolved Hide resolved
tests/test_remote_config.py Outdated Show resolved Hide resolved
firebase_admin/remote_config.py Show resolved Hide resolved
@pijushcs pijushcs merged commit fa8b1b0 into ssrc Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants