Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade io.grpc to 1.60.0 and increase minSdkVersion to 21 #5611

Closed
wants to merge 4 commits into from

Conversation

tom-andersen
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Unit Test Results

     948 files  +   768       948 suites  +768   31m 31s ⏱️ + 27m 25s
  5 178 tests +3 952    5 157 ✔️ +3 947  21 💤 +  5  0 ±0 
10 441 runs  +7 965  10 399 ✔️ +7 955  42 💤 +10  0 ±0 

Results for commit f6762a6. ± Comparison against base commit 16a90fa.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (16a90fa)Merge (46b9c0b)Diff
    aar1.41 MB1.41 MB+415 B (+0.0%)
    apk (aggressive)704 kB704 kB+260 B (+0.0%)
    apk (release)11.2 MB11.5 MB+329 kB (+2.9%)
  • firebase-firestore-ktx

    TypeBase (16a90fa)Merge (46b9c0b)Diff
    aar5.20 kB5.21 kB+2 B (+0.0%)
    apk (aggressive)704 kB705 kB+256 B (+0.0%)
    apk (release)11.2 MB11.5 MB+329 kB (+2.9%)
  • firebase-inappmessaging

    TypeBase (16a90fa)Merge (46b9c0b)Diff
    aar461 kB461 kB+394 B (+0.1%)
    apk (aggressive)1.33 MB1.35 MB+14.4 kB (+1.1%)
    apk (release)11.5 MB11.8 MB+317 kB (+2.7%)
  • firebase-inappmessaging-display

    TypeBase (16a90fa)Merge (46b9c0b)Diff
    apk (aggressive)2.56 MB2.58 MB+14.6 kB (+0.6%)
    apk (release)13.9 MB14.2 MB+320 kB (+2.3%)
  • firebase-inappmessaging-display-ktx

    TypeBase (16a90fa)Merge (46b9c0b)Diff
    apk (aggressive)2.56 MB2.58 MB+14.6 kB (+0.6%)
    apk (release)13.9 MB14.2 MB+320 kB (+2.3%)
  • firebase-inappmessaging-ktx

    TypeBase (16a90fa)Merge (46b9c0b)Diff
    apk (aggressive)1.33 MB1.35 MB+14.4 kB (+1.1%)
    apk (release)11.5 MB11.8 MB+317 kB (+2.7%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mMqJ3sPkCP.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.17% (16a90fa) to 50.13% (46b9c0b) by -0.04%.

    FilenameBase (16a90fa)Merge (46b9c0b)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
  • firebase-firestore

    Overall coverage changed from 44.77% (16a90fa) to 44.84% (46b9c0b) by +0.08%.

    FilenameBase (16a90fa)Merge (46b9c0b)Diff
    FirestoreGrpc.java2.46%3.13%+0.66%
    SetMutation.java94.44%97.22%+2.78%
  • firebase-messaging

    Overall coverage changed from 83.93% (16a90fa) to 84.08% (46b9c0b) by +0.15%.

    FilenameBase (16a90fa)Merge (46b9c0b)Diff
    MessagingAnalytics.java81.60%82.00%+0.40%
    Metadata.java36.51%41.27%+4.76%
  • firebase-storage

    Overall coverage changed from 83.96% (16a90fa) to 83.92% (46b9c0b) by -0.04%.

    FilenameBase (16a90fa)Merge (46b9c0b)Diff
    StreamDownloadTask.java88.89%88.41%-0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/s9TVnjAXhz.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,678 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lSwGsVy7X8/index.html

@tom-andersen tom-andersen deleted the tomandersen/upgradeGrpcApiVersion21 branch December 21, 2023 15:49
@firebase firebase locked and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants