openStream should not be intercepted if Firebase Perf is not initialized #5616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #5584:
Issue
Crash happens if a URL connection is opened e.g.
url.openStream()
whenTransportManager
has not been initialized.Investigation
openStream
inFirebasePerfUrlConnection
intercepts all urls that opens connections.openStream
requiresTransportManager
to be initializedTransportManager
is only initialized afterFirebasePerformance
has been initializedSolution
If
TransportManager
is not initialized, we should simply return the URL openStream and not intercept the connection.