Add diffing for ABT Experiments in real-time RC #5623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesNo release note changes were detected. If you made changes that should be |
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
danasilver
reviewed
Jan 18, 2024
| for (int j = 0; j < affectedKeys.length(); j++) { | ||
| String key = affectedKeys.getString(j); | ||
| JSONObject experimentsCopy = new JSONObject(experiment.toString()); | ||
| // Removing `affectedParameterKeys` because its values never come in the same order which |
There was a problem hiding this comment.
thinking: and because we're diffing the metadata w.r.t. the key(s) itself so we don't need to diff the key
There was a problem hiding this comment.
yeah that makes sense, removed this
danasilver
reviewed
Jan 18, 2024
| @@ -189,6 +193,38 @@ public boolean equals(Object o) { | |||
| return containerJson.toString().equals(that.toString()); | |||
| } | |||
|
|
|||
| /** Creates a map where the key is the config key and the value if the experiment description. */ | |||
There was a problem hiding this comment.
Suggested change
| /** Creates a map where the key is the config key and the value if the experiment description. */ | |
| /** Creates a map where the key is the config key and the value is the experiment description. */ |
| @@ -189,6 +193,38 @@ public boolean equals(Object o) { | |||
| return containerJson.toString().equals(that.toString()); | |||
| } | |||
|
|
|||
| /** Creates a map where the key is the config key and the value if the experiment description. */ | |||
| private Map<String, JSONObject> createExperimentsMap(JSONArray allExperiments) | |||
There was a problem hiding this comment.
I believe this could be static? Though alternatively it could be nice to make it have a similar signature to createRolloutParameterKeyMap work as an instance method so we call this.createExperimentsMap() and other.createExperimentsMap()
There was a problem hiding this comment.
updated to just use instance vars
| @@ -138,23 +139,99 @@ public void getChangedParams_sameP13nMetadata_returnsEmptySet() throws Exception | |||
| } | |||
|
|
|||
| @Test | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds diffing logic between experiments fetched via real-time and experiments active on the device. The config keys that have been affected by the differences will be added to ConfigUpdate. Testing below:
Created experiments with https://docs.google.com/document/d/1MXxUg1JSBbh3m_Qy4tGPrGs3-Nh8FAwKmg5ZWOKQ3J8/edit
Add experiments to configs using Management API, example: https://rpc.corp.google.com/rpc/builder?rpcId=15352346049097272373
2.1) Add/Remove Experiment to Config Key.
2.2) Replace experiment in Config Key
2.3) Create new param with experiment attached
See changes in SDK