Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Remove obsolete special case from tests when verifying "missing index" error message in non-default DB #5632

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Firestore: Remove obsolete special case from tests when verifying "missing index" error message in non-default DB #5632

wants to merge 1 commit into from

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Jan 8, 2024 •
edited
Loading

This PR removes a special case from the integration tests (#5600) that verifies the "missing index" error message returned from the server. Previously, a non-default database would result in a different, less descriptive error message; however, the backend was updated to use the same, descriptive error message for both default and non-default databases. The tests, therefore, should have to the special case removed to increase the coverage of the tests.

Googlers see b/316359394 for more information.

@dconeybe
Firestore: Remove obsolete special case from tests when verifying "mi…
874e973 
…ssing index" error message in non-default DB
@dconeybe dconeybe self-assigned this Jan 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (eb3380e) and merge commit (62c5aba).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6Z6x1zy9IT.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Unit Test Results

   180 files  +   174     180 suites  +174   4m 3s ⏱️ + 3m 45s
1 226 tests +1 207  1 210 ✔️ +1 191  16 💤 +16  0 ❌ ±0 
2 476 runs  +2 438  2 444 ✔️ +2 406  32 💤 +32  0 ❌ ±0 

Results for commit 874e973. ± Comparison against base commit eb3380e.

This pull request removes 19 and adds 1226 tests. Note that renamed tests count towards both. 
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…

com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (eb3380e) and merge commit (62c5aba).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/zfl6GbNaIA.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentileeb3380e62c5abaDiffSignificant (?)
    p10477 ±229 μs365 ±152 μs-113 μs (-23.6%)NO
    p25498 ±231 μs377 ±153 μs-121 μs (-24.3%)NO
    p50524 ±232 μs399 ±157 μs-125 μs (-23.9%)NO
    p75622 ±225 μs487 ±169 μs-135 μs (-21.7%)NO
    p90685 ±206 μs581 ±178 μs-104 μs (-15.2%)NO

    20 test runs in comparison
    CommitTest Runs
    eb3380e
    • 2024-01-05_18:47:45.102608_YtdO
    • 2024-01-05_18:47:45.102643_pltD
    • 2024-01-05_18:47:45.102649_MJkq
    • 2024-01-05_18:47:45.102654_uwlG
    • 2024-01-05_18:47:45.102659_wXcK
    • 2024-01-05_18:47:45.102667_VlHh
    • 2024-01-05_18:47:45.102676_tapf
    • 2024-01-05_18:47:45.102692_bTDF
    • 2024-01-05_18:47:45.102701_McSA
    • 2024-01-05_18:47:45.102708_FFqO
    62c5aba
    • 2024-01-08_19:27:43.635466_HhQE
    • 2024-01-08_19:27:43.635503_MLUL
    • 2024-01-08_19:27:43.635514_Pttg
    • 2024-01-08_19:27:43.635522_BMDV
    • 2024-01-08_19:27:43.635541_rLmo
    • 2024-01-08_19:27:43.635549_JawG
    • 2024-01-08_19:27:43.635556_dJun
    • 2024-01-08_19:27:43.635563_sRRl
    • 2024-01-08_19:27:43.635569_KcdG
    • 2024-01-08_19:27:43.635575_IyZJ
    redfin-30
    Percentileeb3380e62c5abaDiffSignificant (?)
    p10712 ±209 μs666 ±174 μs-46.2 μs (-6.5%)NO
    p25732 ±207 μs694 ±171 μs-38.5 μs (-5.3%)NO
    p50761 ±204 μs734 ±166 μs-27.6 μs (-3.6%)NO
    p75798 ±201 μs791 ±161 μs-7.10 μs (-0.9%)NO
    p90847 ±199 μs892 ±156 μs+45.0 μs (+5.3%)NO

    20 test runs in comparison
    CommitTest Runs
    eb3380e
    • 2024-01-05_18:47:45.102608_YtdO
    • 2024-01-05_18:47:45.102643_pltD
    • 2024-01-05_18:47:45.102649_MJkq
    • 2024-01-05_18:47:45.102654_uwlG
    • 2024-01-05_18:47:45.102659_wXcK
    • 2024-01-05_18:47:45.102667_VlHh
    • 2024-01-05_18:47:45.102676_tapf
    • 2024-01-05_18:47:45.102692_bTDF
    • 2024-01-05_18:47:45.102701_McSA
    • 2024-01-05_18:47:45.102708_FFqO
    62c5aba
    • 2024-01-08_19:27:43.635466_HhQE
    • 2024-01-08_19:27:43.635503_MLUL
    • 2024-01-08_19:27:43.635514_Pttg
    • 2024-01-08_19:27:43.635522_BMDV
    • 2024-01-08_19:27:43.635541_rLmo
    • 2024-01-08_19:27:43.635549_JawG
    • 2024-01-08_19:27:43.635556_dJun
    • 2024-01-08_19:27:43.635563_sRRl
    • 2024-01-08_19:27:43.635569_KcdG
    • 2024-01-08_19:27:43.635575_IyZJ

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileeb3380e62c5abaDiffSignificant (?)
    p10209 ±9.7 ms208 ±4 ms-736 μs (-0.4%)NO
    p25216 ±9 ms215 ±5 ms-334 μs (-0.2%)NO
    p50223 ±10 ms223 ±5 ms+539 μs (+0.2%)NO
    p75231 ±12 ms233 ±6 ms+2.05 ms (+0.9%)NO
    p90240 ±13 ms245 ±9 ms+4.56 ms (+1.9%)NO

    20 test runs in comparison
    CommitTest Runs
    eb3380e
    • 2024-01-05_18:47:45.102608_YtdO
    • 2024-01-05_18:47:45.102643_pltD
    • 2024-01-05_18:47:45.102649_MJkq
    • 2024-01-05_18:47:45.102654_uwlG
    • 2024-01-05_18:47:45.102659_wXcK
    • 2024-01-05_18:47:45.102667_VlHh
    • 2024-01-05_18:47:45.102676_tapf
    • 2024-01-05_18:47:45.102692_bTDF
    • 2024-01-05_18:47:45.102701_McSA
    • 2024-01-05_18:47:45.102708_FFqO
    62c5aba
    • 2024-01-08_19:27:43.635466_HhQE
    • 2024-01-08_19:27:43.635503_MLUL
    • 2024-01-08_19:27:43.635514_Pttg
    • 2024-01-08_19:27:43.635522_BMDV
    • 2024-01-08_19:27:43.635541_rLmo
    • 2024-01-08_19:27:43.635549_JawG
    • 2024-01-08_19:27:43.635556_dJun
    • 2024-01-08_19:27:43.635563_sRRl
    • 2024-01-08_19:27:43.635569_KcdG
    • 2024-01-08_19:27:43.635575_IyZJ
    redfin-30
    Percentileeb3380e62c5abaDiffSignificant (?)
    p10248 ±3 ms272 ±5 ms+23.9 ms (+9.6%)YES
    p25254 ±3 ms278 ±6 ms+24.6 ms (+9.7%)MAYBE
    p50262 ±3 ms287 ±5 ms+25.3 ms (+9.7%)YES
    p75270 ±4 ms296 ±5 ms+26.8 ms (+10.0%)YES
    p90282 ±7 ms311 ±11 ms+29.4 ms (+10.5%)NO

    20 test runs in comparison
    CommitTest Runs
    eb3380e
    • 2024-01-05_18:47:45.102608_YtdO
    • 2024-01-05_18:47:45.102643_pltD
    • 2024-01-05_18:47:45.102649_MJkq
    • 2024-01-05_18:47:45.102654_uwlG
    • 2024-01-05_18:47:45.102659_wXcK
    • 2024-01-05_18:47:45.102667_VlHh
    • 2024-01-05_18:47:45.102676_tapf
    • 2024-01-05_18:47:45.102692_bTDF
    • 2024-01-05_18:47:45.102701_McSA
    • 2024-01-05_18:47:45.102708_FFqO
    62c5aba
    • 2024-01-08_19:27:43.635466_HhQE
    • 2024-01-08_19:27:43.635503_MLUL
    • 2024-01-08_19:27:43.635514_Pttg
    • 2024-01-08_19:27:43.635522_BMDV
    • 2024-01-08_19:27:43.635541_rLmo
    • 2024-01-08_19:27:43.635549_JawG
    • 2024-01-08_19:27:43.635556_dJun
    • 2024-01-08_19:27:43.635563_sRRl
    • 2024-01-08_19:27:43.635569_KcdG
    • 2024-01-08_19:27:43.635575_IyZJ

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/2Snqv31IIL/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dconeybe dconeybe

Labels
api: firestore do-not-merge/work-in-progress main-merge-ack size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @google-oss-bot