-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataconnect: fix cache key conflict on nighty integration tests runs #6667
Merged
dconeybe
merged 6 commits into
main
from
dconeybe/dataconnect/GHAIntegrationTestsCacheKeyConflictFix
Feb 7, 2025
Merged
dataconnect: fix cache key conflict on nighty integration tests runs #6667
dconeybe
merged 6 commits into
main
from
dconeybe/dataconnect/GHAIntegrationTestsCacheKeyConflictFix
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesNo release note changes were detected. If you made changes that should be |
Vertex AI Mock Responses Check
|
Size Report 1Affected ProductsNo changes between base commit (dedff68) and merge commit (2c41a71).Test Logs |
Coverage Report 1This report is too large (239,485 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
aashishpatil-g
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly github actions runs of the
.github/workflows/dataconnect.yml
workflow would always fail to create new cache entries for the gradle build cache and avd cache due to the cache with the given name already existing. To remedy this, the caches now have the unique run_id appended.For example, in https://github.com/firebase/firebase-android-sdk/actions/runs/13134051569/job/36645359232 the following errors (which were ignored) occurred when trying to save the cache, and will be fixed by this PR: