Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconnect: fix cache key conflict on nighty integration tests runs #6667

Merged

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Feb 4, 2025

The nightly github actions runs of the .github/workflows/dataconnect.yml workflow would always fail to create new cache entries for the gradle build cache and avd cache due to the cache with the given name already existing. To remedy this, the caches now have the unique run_id appended.

For example, in https://github.com/firebase/firebase-android-sdk/actions/runs/13134051569/job/36645359232 the following errors (which were ignored) occurred when trying to save the cache, and will be fixed by this PR:

Failed to save: Unable to reserve cache with key gradle-cache-jqnvfzw6w7, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/main, Key: gradle-cache-jqnvfzw6w7, Version: 569019faed09f5f63af8a1ab2f5e0433d94f66e572509c03e0e3df35d24400c7
...
Failed to save: Unable to reserve cache with key avd-cache-zhdsn586je-api34, another job may be creating this cache. More details: Cache already exists. Scope: refs/heads/main, Key: avd-cache-zhdsn586je-api34, Version: f969ff318f56045ef08ffb47bd4c5184fcbdf11d730c56809adddc4140471d78

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v6.1

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Test Results

 1 034 files  ±0   1 034 suites  ±0   34m 21s ⏱️ +13s
 5 888 tests ±0   5 866 ✅ ±0  22 💤 ±0  0 ❌ ±0 
11 839 runs  ±0  11 795 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 2cfa624. ± Comparison against base commit dedff68.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 4, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 4, 2025

Coverage Report 1

This report is too large (239,485 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ckZKu4KNKP.html

@dconeybe dconeybe marked this pull request as ready for review February 4, 2025 20:20
@dconeybe dconeybe enabled auto-merge (squash) February 7, 2025 23:23
@dconeybe dconeybe merged commit 336cf32 into main Feb 7, 2025
264 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/GHAIntegrationTestsCacheKeyConflictFix branch February 7, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants