Use lazy encoding in utf-8 encoded string comparison #6706
+364
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-firestore### {{firestore}} version 25.1.3 {: #firestore_v25-1-3}
* {{fixed}} Use lazy encoding in UTF-8 encoded byte comparison for strings to solve performance issues. GitHub [#6706](//github.com/firebase/firebase-android-sdk/issues/6706){: .external}
#### {{firestore}} Kotlin extensions version 25.1.3 {: #firestore-ktx_v25-1-3}
The Kotlin extensions library transitively includes the updated
`firebase-firestore` library. The Kotlin extensions library has no additional
updates.
|
Coverage Report 1Affected Products
Test Logs |
Test Results 186 files + 166 186 suites +166 4m 44s ⏱️ + 4m 32s Results for commit 8159f25. ± Comparison against base commit 95bbf92. This pull request removes 116 and adds 1235 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Size Report 1Affected Products
Test Logs |
ehsannas
reviewed
Feb 19, 2025
| return Integer.compare(leftCodePoint, rightCodePoint); | ||
| } else { | ||
| // substring and do UTF-8 encoded byte comparison | ||
| byte[] leftBytes = getUtf8SafeBytes(left, i); |
There was a problem hiding this comment.
would it be wrong to always take (index, index+2), and compare those?
meaning, getting rid of getUtf8SafeBytes()
There was a problem hiding this comment.
Based on the unit test results, yes, somehow it is problematic for java, while js managed to handle it nicely. But, increasing i one by one + getUtf8SafeBytes() solved the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix created a performance issue due to expensive UTF-8 encoding. Update
compareUtf8Stringsto use lazy encoding instead.