Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing optIn declarations to reduce compilation noise #6713

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Feb 22, 2025

Part of the serialization API we use requires optIn, and without the correct declarations we get warnings printed when compiling the code.

Part of the serialization API we use requires optIn, and without the
correct declarations we get warnings printed when compiling the code.
@rlazo rlazo requested review from daymxn and davidmotson February 22, 2025 05:30
Copy link
Contributor

github-actions bot commented Feb 22, 2025

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/vertexai/type/FinishReason.html	2025-02-24 18:15:45.911104887 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/vertexai/type/FinishReason.html	2025-02-24 18:13:38.616309183 +0000
@@ -46,70 +46,70 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#BLOCKLIST()">BLOCKLIST</a></code></div>
               <p>Token generation stopped because the content contains forbidden terms.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#MALFORMED_FUNCTION_CALL()">MALFORMED_FUNCTION_CALL</a></code></div>
               <p>The function call generated by the model is invalid.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#MAX_TOKENS()">MAX_TOKENS</a></code></div>
               <p>Model hit the token limit.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#OTHER()">OTHER</a></code></div>
               <p>Model stopped for another reason.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#PROHIBITED_CONTENT()">PROHIBITED_CONTENT</a></code></div>
               <p>Token generation stopped for potentially containing prohibited content.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#RECITATION()">RECITATION</a></code></div>
               <p>The token generation was stopped because the response was flagged for unauthorized citations.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#SAFETY()">SAFETY</a></code></div>
               <p><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code> prevented the model from outputting content.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#SPII()">SPII</a></code></div>
               <p>Token generation stopped because the content potentially contains Sensitive Personally Identifiable Information (SPII).</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#STOP()">STOP</a></code></div>
               <p>Model finished successfully and stopped.</p>
             </td>
           </tr>
           <tr>
-            <td><code>static&nbsp;final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
+            <td><code>final @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#UNKNOWN()">UNKNOWN</a></code></div>
               <p>A new and not yet supported value.</p>
@@ -136,52 +136,52 @@
       <h2>Public fields</h2>
       <div class="api-item"><a name="getBLOCKLIST()"></a><a name="setBLOCKLIST()"></a><a name="getBLOCKLIST--"></a><a name="setBLOCKLIST--"></a>
         <h3 class="api-name" id="BLOCKLIST()">BLOCKLIST</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#BLOCKLIST()">BLOCKLIST</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#BLOCKLIST()">BLOCKLIST</a></pre>
         <p>Token generation stopped because the content contains forbidden terms.</p>
       </div>
       <div class="api-item"><a name="getMALFORMED_FUNCTION_CALL()"></a><a name="setMALFORMED_FUNCTION_CALL()"></a><a name="getMALFORMED_FUNCTION_CALL--"></a><a name="setMALFORMED_FUNCTION_CALL--"></a>
         <h3 class="api-name" id="MALFORMED_FUNCTION_CALL()">MALFORMED_FUNCTION_CALL</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#MALFORMED_FUNCTION_CALL()">MALFORMED_FUNCTION_CALL</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#MALFORMED_FUNCTION_CALL()">MALFORMED_FUNCTION_CALL</a></pre>
         <p>The function call generated by the model is invalid.</p>
       </div>
       <div class="api-item"><a name="getMAX_TOKENS()"></a><a name="setMAX_TOKENS()"></a><a name="getMAX_TOKENS--"></a><a name="setMAX_TOKENS--"></a>
         <h3 class="api-name" id="MAX_TOKENS()">MAX_TOKENS</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#MAX_TOKENS()">MAX_TOKENS</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#MAX_TOKENS()">MAX_TOKENS</a></pre>
         <p>Model hit the token limit.</p>
       </div>
       <div class="api-item"><a name="getOTHER()"></a><a name="setOTHER()"></a><a name="getOTHER--"></a><a name="setOTHER--"></a>
         <h3 class="api-name" id="OTHER()">OTHER</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#OTHER()">OTHER</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#OTHER()">OTHER</a></pre>
         <p>Model stopped for another reason.</p>
       </div>
       <div class="api-item"><a name="getPROHIBITED_CONTENT()"></a><a name="setPROHIBITED_CONTENT()"></a><a name="getPROHIBITED_CONTENT--"></a><a name="setPROHIBITED_CONTENT--"></a>
         <h3 class="api-name" id="PROHIBITED_CONTENT()">PROHIBITED_CONTENT</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#PROHIBITED_CONTENT()">PROHIBITED_CONTENT</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#PROHIBITED_CONTENT()">PROHIBITED_CONTENT</a></pre>
         <p>Token generation stopped for potentially containing prohibited content.</p>
       </div>
       <div class="api-item"><a name="getRECITATION()"></a><a name="setRECITATION()"></a><a name="getRECITATION--"></a><a name="setRECITATION--"></a>
         <h3 class="api-name" id="RECITATION()">RECITATION</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#RECITATION()">RECITATION</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#RECITATION()">RECITATION</a></pre>
         <p>The token generation was stopped because the response was flagged for unauthorized citations.</p>
       </div>
       <div class="api-item"><a name="getSAFETY()"></a><a name="setSAFETY()"></a><a name="getSAFETY--"></a><a name="setSAFETY--"></a>
         <h3 class="api-name" id="SAFETY()">SAFETY</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#SAFETY()">SAFETY</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#SAFETY()">SAFETY</a></pre>
         <p><code><a href="/docs/reference/android/com/google/firebase/vertexai/type/SafetySetting.html">SafetySetting</a></code> prevented the model from outputting content.</p>
       </div>
       <div class="api-item"><a name="getSPII()"></a><a name="setSPII()"></a><a name="getSPII--"></a><a name="setSPII--"></a>
         <h3 class="api-name" id="SPII()">SPII</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#SPII()">SPII</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#SPII()">SPII</a></pre>
         <p>Token generation stopped because the content potentially contains Sensitive Personally Identifiable Information (SPII).</p>
       </div>
       <div class="api-item"><a name="getSTOP()"></a><a name="setSTOP()"></a><a name="getSTOP--"></a><a name="setSTOP--"></a>
         <h3 class="api-name" id="STOP()">STOP</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#STOP()">STOP</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#STOP()">STOP</a></pre>
         <p>Model finished successfully and stopped.</p>
       </div>
       <div class="api-item"><a name="getUNKNOWN()"></a><a name="setUNKNOWN()"></a><a name="getUNKNOWN--"></a><a name="setUNKNOWN--"></a>
         <h3 class="api-name" id="UNKNOWN()">UNKNOWN</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;static&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#UNKNOWN()">UNKNOWN</a></pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;final&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.html">FinishReason</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/vertexai/type/FinishReason.Companion.html#UNKNOWN()">UNKNOWN</a></pre>
         <p>A new and not yet supported value.</p>
       </div>
       <div class="api-item"><a name="getName()"></a><a name="setName()"></a><a name="getName--"></a><a name="setName--"></a>

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 22, 2025

Coverage Report 1

Affected Products

No changes between base commit (680ce8c) and merge commit (ff83567).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/OUKIrtVwVA.html

Copy link
Contributor

github-actions bot commented Feb 22, 2025

Test Results

 20 files  ±0   20 suites  ±0   12s ⏱️ ±0s
116 tests ±0  116 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 60339e7. ± Comparison against base commit 680ce8c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 22, 2025

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (680ce8c)Merge (ff83567)Diff
    aar576 kB576 kB-301 B (-0.1%)
    apk (aggressive)1.40 MB1.40 MB-144 B (-0.0%)
    apk (release)9.36 MB9.36 MB-192 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mVcJDdxevH.html

@rlazo rlazo merged commit 22be120 into main Feb 24, 2025
30 checks passed
@rlazo rlazo deleted the rl.vertex.optin.add branch February 24, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants