-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribute FTL tests amongst different device models #1468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype. This allows us to randomly select FTL devices to distribute the load.
jonsimantov
added
the
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
label
Oct 10, 2023
jonsimantov
added
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
and removed
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
labels
Oct 10, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
labels
Oct 10, 2023
❌ Integration test FAILEDRequested by @jonsimantov on commit b50057e
Add flaky tests to go/fpl-cpp-flake-tracker |
jonsimantov
added
the
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
label
Oct 10, 2023
github-actions
bot
removed
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
tests: failed
This PR's integration tests failed.
labels
Oct 10, 2023
github-actions
bot
added
tests: succeeded
This PR's integration tests succeeded.
and removed
tests: failed
This PR's integration tests failed.
labels
Oct 11, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Oct 11, 2023
LGTM |
sunmou99
approved these changes
Oct 11, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests: succeeded
This PR's integration tests succeeded.
labels
Oct 11, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Oct 11, 2023
jonsimantov
added
the
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
label
Oct 11, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: succeeded
This PR's integration tests succeeded.
and removed
tests-requested: full
Trigger a FULL set of integration tests (uses expanded test matrix).
tests: failed
This PR's integration tests failed.
labels
Oct 11, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Oct 12, 2023
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: succeeded
This PR's integration tests succeeded.
labels
Oct 12, 2023
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Distributing the load will help prevent issues with a single FTL device type from bottlenecking the tests.
Depends on FirebaseExtended/github-actions#7 being merged and a new release of the firebase-test-lab action created.
Testing
Running expanded tests on this PR.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.