Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip a UMP test that doesn't work on iOS simulator. #1472

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Skip a UMP test that doesn't work on iOS simulator. #1472

merged 2 commits into from
Oct 11, 2023

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Oct 11, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

The OperationInProgress test fails on iOS simulator due to the LoadAndShow method being too quick, so disable it on that platform.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov changed the title Don't run a UMP test that doesn't work on iOS simulator. Skip a UMP test that doesn't work on iOS simulator. Oct 11, 2023
@jonsimantov jonsimantov requested a review from a-maurice October 11, 2023 23:52
@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Oct 11, 2023
@jonsimantov jonsimantov merged commit 314ac67 into main Oct 11, 2023
33 of 47 checks passed
@jonsimantov jonsimantov deleted the ump-fix-quick-test branch October 11, 2023 23:54
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 314ac67
Last updated: Wed Oct 11 19:44 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsCanReturnEstimatedValue

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Oct 12, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 12, 2023
@firebase firebase locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice