Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validation tests on inequality restrictions #1474

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Remove validation tests on inequality restrictions #1474

merged 1 commit into from
Oct 13, 2023

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Oct 13, 2023 •
edited
Loading

Android and iOS SDKs added multiple inequality support recently firebase/firebase-ios-sdk#11626, firebase/firebase-android-sdk#5194, where 2 restrictions get lifted on inequality queries:

  • All inequality filters must reference the same field.
  • The first ordering must be the same field as an inequality filter

The validation tests on above restrictions can be removed now.

@milaGGL milaGGL added the skip-release-notes Skip release notes check label Oct 13, 2023
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Oct 13, 2023
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Oct 13, 2023
@github-actions
Copy link

github-actions bot commented Oct 13, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @jonsimantov on commit a139319
Last updated: Fri Oct 13 12:29 PDT 2023
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Oct 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 13, 2023
@github-actions github-actions bot added tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Oct 13, 2023
@jonsimantov jonsimantov self-requested a review October 13, 2023 17:49
@jonsimantov jonsimantov merged commit a139319 into main Oct 13, 2023
67 of 80 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Oct 13, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Oct 13, 2023
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milaGGL @jonsimantov