Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to wait and retry futures based on multiple expected … #1514

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Jan 11, 2024

…errors.

Description

Provide details of the change, and generalize the change in the PR title above.

This will be used in subsequent PRs to clean up the retry logic for flaky tests.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Jan 11, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 11, 2024
Copy link

github-actions bot commented Jan 11, 2024

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 4894109
Last updated: Fri Jan 12 17:18 PST 2024
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  WriteBatchTest.TestBatchesFailAtomicallyRaisingCorrectEvents
gma [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 11, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 11, 2024
@jonsimantov jonsimantov requested a review from a-maurice January 11, 2024 19:22
@jonsimantov jonsimantov marked this pull request as ready for review January 11, 2024 19:24
@jonsimantov jonsimantov merged commit 4894109 into main Jan 12, 2024
59 of 77 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jan 12, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 13, 2024
@firebase firebase locked and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants