-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a more generic method to get a server timestamp for mobile tests. #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
added
tests-requested: quick
Trigger a quick set of integration tests.
skip-release-notes
Skip release notes check
labels
Jan 23, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Jan 23, 2024
❌ Integration test FAILEDRequested by @jonsimantov on commit 1c76fd3
Add flaky tests to go/fpl-cpp-flake-tracker |
jonsimantov
added
the
tests-requested: quick
Trigger a quick set of integration tests.
label
Jan 24, 2024
github-actions
bot
removed
tests-requested: quick
Trigger a quick set of integration tests.
tests: failed
This PR's integration tests failed.
labels
Jan 24, 2024
jonsimantov
added
the
tests-requested: quick
Trigger a quick set of integration tests.
label
Jan 24, 2024
github-actions
bot
added
tests: failed
This PR's integration tests failed.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
labels
Jan 24, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jan 24, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: failed
This PR's integration tests failed.
labels
Jan 24, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jan 24, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: failed
This PR's integration tests failed.
labels
Jan 24, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Jan 24, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
tests: failed
This PR's integration tests failed.
labels
Feb 9, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Feb 9, 2024
This reverts commit b691a64.
jonsimantov
added
the
tests-requested: quick
Trigger a quick set of integration tests.
label
Feb 11, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: succeeded
This PR's integration tests succeeded.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
tests: failed
This PR's integration tests failed.
labels
Feb 11, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Feb 11, 2024
jonsimantov
added
the
tests-requested: quick
Trigger a quick set of integration tests.
label
Feb 12, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: succeeded
This PR's integration tests succeeded.
and removed
tests-requested: quick
Trigger a quick set of integration tests.
tests: succeeded
This PR's integration tests succeeded.
labels
Feb 12, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Feb 12, 2024
cynthiajoan
approved these changes
Feb 12, 2024
github-actions
bot
added
tests: in-progress
This PR's integration tests are in progress.
tests: failed
This PR's integration tests failed.
and removed
tests: succeeded
This PR's integration tests succeeded.
labels
Feb 12, 2024
firebase-workflow-trigger
bot
removed
the
tests: in-progress
This PR's integration tests are in progress.
label
Feb 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because FTL devices can occasionally have the wrong locally set date, change the tests to fetch time from a publicly-accessible server. If it fails at any point, falls back to local device time.
Testing
You can see the remote timestamp in the test run here.
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.