Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SetConsent test to the end to not break GetAnalyticsInstanceId tests. #1529

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

jonsimantov
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

On Android, once SetConsent is called denying consent, calling it again allowing consent doesn't always take affect until the app restarts.

So move SetConsent to the end of the tests, and ensure that if it's run earlier (due to test order being randomized), skip the tests that can fail.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added skip-release-notes Skip release notes check tests-requested: quick Trigger a quick set of integration tests. labels Jan 24, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jan 24, 2024
Copy link

github-actions bot commented Jan 24, 2024

✅  Integration test succeeded!

Requested by @jonsimantov on commit 9f5985a
Last updated: Fri Jan 26 12:19 PST 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 24, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 24, 2024
@jonsimantov jonsimantov requested a review from a-maurice January 25, 2024 00:35
@jonsimantov jonsimantov marked this pull request as ready for review January 25, 2024 23:43
@jonsimantov jonsimantov merged commit 9f5985a into main Jan 26, 2024
28 of 30 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Jan 26, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 26, 2024
@firebase firebase locked and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants