Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal Updates #1539

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Internal Updates #1539

merged 2 commits into from
Feb 15, 2024

Conversation

nakirekommula
Copy link
Contributor

Description

Adds AdListener support for NativeAd.

Testing

N/A

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

Internal Updates only.

@nakirekommula nakirekommula added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Feb 15, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 15, 2024 •
edited
Loading

❌  Integration test FAILED

Requested by @nakirekommula on commit 3fd90d5
Last updated: Thu Feb 15 16:47 PST 2024
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [2/3 os: macos ubuntu] [1/2 android_device: android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Feb 15, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 15, 2024
@jonsimantov
Copy link
Contributor

Will any of this break with the iOS 11.0.1 release? (I'm in the process of updating to it now.)

@nakirekommula
Copy link
Contributor Author

Will any of this break with the iOS 11.0.1 release? (I'm in the process of updating to it now.)

Doesn't look like workflows related to adlistener are changed in the recent release. So this update should be compatible.

jonsimantov
jonsimantov approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one small issue

gma/src/android/gma_android.cc Show resolved Hide resolved
@nakirekommula
Copy link
Contributor Author

Approved with one small issue

Addressed the comment. Thank you for the quick review Jon!

@nakirekommula nakirekommula merged commit 3fd90d5 into main Feb 15, 2024
30 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 15, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 16, 2024
@firebase firebase locked and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nakirekommula @jonsimantov