Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android SDK versions for I/O release. #1569

Merged
merged 5 commits into from
May 1, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Apr 16, 2024

Description

Provide details of the change, and generalize the change in the PR title above.

Changes in this update:

  • Raise minSdkVersion to 21
  • Raise targetSdkVersion to 34
  • Raise compileSdkVersion to 34
  • Add android:exported="true" to AndroidManifest.xml files

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Testing via integration tests in this PR.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 16, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 16, 2024
Copy link

github-actions bot commented Apr 16, 2024

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit de498a6
Last updated: Wed May 1 13:56 PDT 2024
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
[TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: emulator_ftl_target]
(3 failed tests)  FirebaseAppCheckTest.TestAddTokenChangedListener
  FirebaseAppCheckTest.TestGetTokenForcingRefresh
  FirebaseAppCheckTest.TestGetTokenLastResult
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseRemoteConfigTest.TestFetchSecondsParameter

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 16, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 16, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 17, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 17, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 17, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 18, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 18, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 18, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 23, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 23, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 23, 2024
@jonsimantov jonsimantov marked this pull request as ready for review April 30, 2024 18:05
@jonsimantov jonsimantov requested a review from a-maurice April 30, 2024 18:05
@jonsimantov jonsimantov enabled auto-merge (squash) May 1, 2024 18:13
@jonsimantov jonsimantov merged commit de498a6 into main May 1, 2024
30 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels May 1, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 1, 2024
@firebase firebase locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants